Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Unified Diff: third_party/WebKit/Source/devtools/front_end/main/Main.js

Issue 2706293007: [DevTools] Fix Dialog's close button to properly close dialog. (Closed)
Patch Set: test Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/main/Main.js
diff --git a/third_party/WebKit/Source/devtools/front_end/main/Main.js b/third_party/WebKit/Source/devtools/front_end/main/Main.js
index d4d3ecb9cea3855113fa2080d3e92c86a59e6494..1b3f39840b8cb2d81bc09ed491e83a0f5519f55f 100644
--- a/third_party/WebKit/Source/devtools/front_end/main/Main.js
+++ b/third_party/WebKit/Source/devtools/front_end/main/Main.js
@@ -875,7 +875,7 @@ Main.RemoteDebuggingTerminatedScreen = class extends UI.VBox {
dialog.addCloseButton();
dialog.setDimmed(true);
new Main.RemoteDebuggingTerminatedScreen(reason).show(dialog.contentElement);
- dialog.showDialog();
+ dialog.show();
}
};
@@ -905,11 +905,11 @@ Main.TargetCrashedScreen = class extends UI.VBox {
dialog.setSizeBehavior(UI.GlassPane.SizeBehavior.MeasureContent);
dialog.addCloseButton();
dialog.setDimmed(true);
- var hideBound = dialog.hideDialog.bind(dialog);
+ var hideBound = dialog.hide.bind(dialog);
debuggerModel.addEventListener(SDK.DebuggerModel.Events.GlobalObjectCleared, hideBound);
new Main.TargetCrashedScreen(onHide).show(dialog.contentElement);
- dialog.showDialog();
+ dialog.show();
function onHide() {
debuggerModel.removeEventListener(SDK.DebuggerModel.Events.GlobalObjectCleared, hideBound);

Powered by Google App Engine
This is Rietveld 408576698