third_party/WebKit/Source/devtools/front_end/perf_ui/FilmStripView.js - Issue 2706293007: [DevTools] Fix Dialog's close button to properly close dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/perf_ui/FilmStripView.js

Issue 2706293007: [DevTools] Fix Dialog's close button to properly close dialog. (Closed)

Patch Set: test Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js ('k') | third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/perf_ui/FilmStripView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/perf_ui/FilmStripView.js b/third_party/WebKit/Source/devtools/front_end/perf_ui/FilmStripView.js

index 6e822193ff33c828f9672e31592a1112856c2ca6..ee0774cec6b99cc8274943a15f752e6fbeef9a96 100644

--- a/third_party/WebKit/Source/devtools/front_end/perf_ui/FilmStripView.js

+++ b/third_party/WebKit/Source/devtools/front_end/perf_ui/FilmStripView.js

@@ -241,7 +241,7 @@ PerfUI.FilmStripView.Dialog = class extends UI.VBox {

if (!this._dialog) {

this._dialog = new UI.Dialog();

this.show(this._dialog.contentElement);

- this._dialog.showDialog();

+ this._dialog.show();

}

this._dialog.setSizeBehavior(UI.GlassPane.SizeBehavior.MeasureContent);

}