Fix DCHECK hit on component policy fetch with empty ID

Fix DCHECK hit on component policy fetch with empty ID

The DCHECK was caused by the attempt to wipe the cache data with
an empty subkey, which is not allowed by policy::ResourceCache.

This CL ensures that such invalid policy gets immediately discarded
at the validation phase, without reaching the later steps like
touching cache.

BUG=694712
TEST=New unit tests;
     Manual test against current revision of YAPS (policy test server),
     which is currently erroneously sending such invalid component
     policy responses.

Review-Url: https://codereview.chromium.org/2706293005
Cr-Commit-Position: refs/heads/master@{#452048}
Committed: https://chromium.googlesource.com/chromium/src/+/ad9fcff98d11896c40edf5d0e9fca2c005b31fd2

[emaxx, 2017-02-21 21:39:42]

The CQ bit was checked by emaxx@chromium.org to run a CQ dry run

[emaxx, 2017-02-21 21:40:06]

emaxx@chromium.org changed reviewers:
+ atwilson@chromium.org

[emaxx, 2017-02-21 21:40:07]

Drew, PTAL.

[commit-bot: I haz the power, 2017-02-21 21:41:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 23:44:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 23:44:54]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[Andrew T Wilson (Slow), 2017-02-22 11:31:26]

lgtm

[emaxx, 2017-02-22 14:22:46]

Description was changed from

==========
Fix DCHECK hit on component policy fetch with empty ID

The DCHECK was caused by the attempt to wipe the cache data with
an empty subkey, which is not allowed by policy::ResourceCache.

This CL ensure that such invalid policy gets immediately discarded
at the validation phase, without reaching the later steps like
touching cache.

BUG=694712
TEST=New unit tests;
     Manual test against current revision of YAPS )policy test server),
     which is currently erroneously sending such invalid component
     policy responses.
==========

to

==========
Fix DCHECK hit on component policy fetch with empty ID

The DCHECK was caused by the attempt to wipe the cache data with
an empty subkey, which is not allowed by policy::ResourceCache.

This CL ensures that such invalid policy gets immediately discarded
at the validation phase, without reaching the later steps like
touching cache.

BUG=694712
TEST=New unit tests;
     Manual test against current revision of YAPS )policy test server),
     which is currently erroneously sending such invalid component
     policy responses.
==========

[emaxx, 2017-02-22 14:24:03]

Description was changed from

==========
Fix DCHECK hit on component policy fetch with empty ID

The DCHECK was caused by the attempt to wipe the cache data with
an empty subkey, which is not allowed by policy::ResourceCache.

This CL ensures that such invalid policy gets immediately discarded
at the validation phase, without reaching the later steps like
touching cache.

BUG=694712
TEST=New unit tests;
     Manual test against current revision of YAPS )policy test server),
     which is currently erroneously sending such invalid component
     policy responses.
==========

to

==========
Fix DCHECK hit on component policy fetch with empty ID

The DCHECK was caused by the attempt to wipe the cache data with
an empty subkey, which is not allowed by policy::ResourceCache.

This CL ensures that such invalid policy gets immediately discarded
at the validation phase, without reaching the later steps like
touching cache.

BUG=694712
TEST=New unit tests;
     Manual test against current revision of YAPS (policy test server),
     which is currently erroneously sending such invalid component
     policy responses.
==========

[emaxx, 2017-02-22 14:24:11]

The CQ bit was checked by emaxx@chromium.org

[commit-bot: I haz the power, 2017-02-22 14:24:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 14:58:33]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487773451191500, "parent_rev":
"53a17807c9046399134294373031a0633e75e3d6", "commit_rev":
"ad9fcff98d11896c40edf5d0e9fca2c005b31fd2"}

[commit-bot: I haz the power, 2017-02-22 14:59:08]

Description was changed from

==========
Fix DCHECK hit on component policy fetch with empty ID

The DCHECK was caused by the attempt to wipe the cache data with
an empty subkey, which is not allowed by policy::ResourceCache.

This CL ensures that such invalid policy gets immediately discarded
at the validation phase, without reaching the later steps like
touching cache.

BUG=694712
TEST=New unit tests;
     Manual test against current revision of YAPS (policy test server),
     which is currently erroneously sending such invalid component
     policy responses.
==========

to

==========
Fix DCHECK hit on component policy fetch with empty ID

The DCHECK was caused by the attempt to wipe the cache data with
an empty subkey, which is not allowed by policy::ResourceCache.

This CL ensures that such invalid policy gets immediately discarded
at the validation phase, without reaching the later steps like
touching cache.

BUG=694712
TEST=New unit tests;
     Manual test against current revision of YAPS (policy test server),
     which is currently erroneously sending such invalid component
     policy responses.

Review-Url: https://codereview.chromium.org/2706293005
Cr-Commit-Position: refs/heads/master@{#452048}
Committed:
https://chromium.googlesource.com/chromium/src/+/ad9fcff98d11896c40edf5d0e9fc...
==========

[commit-bot: I haz the power, 2017-02-22 14:59:09]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ad9fcff98d11896c40edf5d0e9fc...