components/policy/core/common/cloud/component_cloud_policy_store.cc - Issue 2706293005: Fix DCHECK hit on component policy fetch with empty ID

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/cloud/component_cloud_policy_store.cc

Issue 2706293005: Fix DCHECK hit on component policy fetch with empty ID (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/policy/core/common/cloud/component_cloud_policy_store.cc

diff --git a/components/policy/core/common/cloud/component_cloud_policy_store.cc b/components/policy/core/common/cloud/component_cloud_policy_store.cc

index 93617d8d7e983affad3de065024a0e407013ca0f..29c8dd418b8fc9c4f12b11ca9cfc628cb8f134f6 100644

--- a/components/policy/core/common/cloud/component_cloud_policy_store.cc

+++ b/components/policy/core/common/cloud/component_cloud_policy_store.cc

@@ -289,6 +289,10 @@ bool ComponentCloudPolicyStore::ValidatePolicy(

LOG(ERROR) << "Bad policy type";

return false;

}

+ if (ns.component_id.empty()) {

+ LOG(ERROR) << "Empty component id";

+ return false;

+ }

if (username_.empty() || dm_token_.empty() || device_id_.empty() ||

public_key_.empty() || public_key_version_ == -1) {

« no previous file with comments | « no previous file | components/policy/core/common/cloud/component_cloud_policy_store_unittest.cc » ('j') | no next file with comments »