Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 2706183002: Fix flaky tests by disabling DeviceDiscoveryNotification service. (Closed)

Created:
3 years, 10 months ago by Vitaly Buka (NO REVIEWS)
Modified:
3 years, 10 months ago
Reviewers:
Lei Zhang, rbpotter
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flaky tests by disabling DeviceDiscoveryNotification service. Tests assume that nothing else uses local discovery code. BUG=689305, 660669 Review-Url: https://codereview.chromium.org/2706183002 Cr-Commit-Position: refs/heads/master@{#452275} Committed: https://chromium.googlesource.com/chromium/src/+/83cfba4c65a0a545656dfb2babe8a423be83fd62

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/browser/extensions/api/gcd_private/gcd_private_apitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (11 generated)
Vitaly Buka (NO REVIEWS)
3 years, 10 months ago (2017-02-21 10:36:46 UTC) #4
Vitaly Buka (NO REVIEWS)
3 years, 10 months ago (2017-02-21 21:02:30 UTC) #9
Lei Zhang
lgtm
3 years, 10 months ago (2017-02-22 22:18:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2706183002/1
3 years, 10 months ago (2017-02-22 22:19:38 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 23:44:12 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/83cfba4c65a0a545656dfb2babe8...

Powered by Google App Engine
This is Rietveld 408576698