Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Unified Diff: chrome/browser/extensions/api/gcd_private/gcd_private_apitest.cc

Issue 2706183002: Fix flaky tests by disabling DeviceDiscoveryNotification service. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/webui/local_discovery/local_discovery_ui_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/gcd_private/gcd_private_apitest.cc
diff --git a/chrome/browser/extensions/api/gcd_private/gcd_private_apitest.cc b/chrome/browser/extensions/api/gcd_private/gcd_private_apitest.cc
index 52a68209bf6802466bbbeed4df01e8218f520971..d948ac1eae804f62556f4405e648175d23f3e826 100644
--- a/chrome/browser/extensions/api/gcd_private/gcd_private_apitest.cc
+++ b/chrome/browser/extensions/api/gcd_private/gcd_private_apitest.cc
@@ -90,6 +90,7 @@ class GcdPrivateAPITest : public ExtensionApiTest {
command_line->AppendSwitchASCII(
extensions::switches::kWhitelistedExtensionID,
"ddchlicdkolnonkihahngkmmmjnjlkkf");
+ command_line->AppendSwitch(switches::kDisableDeviceDiscoveryNotifications);
}
std::unique_ptr<net::FakeURLFetcher> CreateFakeURLFetcher(
@@ -142,8 +143,7 @@ class GcdPrivateWithMdnsAPITest : public GcdPrivateAPITest {
test_service_discovery_client_;
};
-// Flaky on Linux(dbg). https://crbug.com/689305
-IN_PROC_BROWSER_TEST_F(GcdPrivateWithMdnsAPITest, DISABLED_DeviceInfo) {
+IN_PROC_BROWSER_TEST_F(GcdPrivateWithMdnsAPITest, DeviceInfo) {
test_service_discovery_client_->SimulateReceive(kAnnouncePacket,
sizeof(kAnnouncePacket));
url_fetcher_factory_.SetFakeResponse(GURL("http://1.2.3.4:8888/privet/info"),
« no previous file with comments | « no previous file | chrome/browser/ui/webui/local_discovery/local_discovery_ui_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698