Add clean layout DCHECK to mostForwardCaretPosition()

Add clean layout DCHECK to mostForwardCaretPosition()

This patch adds clean layout |DCHECK()| to |mostForwardCaretPosition()|, and
fixes call sites calling it with dirty layout tree, to make sure we don't call
it with dirty layout tree.

We could not have this |DCHECK()| since we call |mostForwardCaretPosition()|
during node removal, but patch[1] made not to do so.

This patch is similar to patch[2], which is for |mostBackwardCaretPosition()|.

[1] http://crrev.com/2680943004 Make FrameSelection to hold non-canonicalized positions
[2] http://crrev.com/2705113003 Add clean layout DCHECK to mostBackwardCaretPosition()

BUG=694413
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2706163002
Cr-Commit-Position: refs/heads/master@{#451874}
Committed: https://chromium.googlesource.com/chromium/src/+/22a030be0c75c7a39b938d51d04bcc259bf9fe17

[yosin_UTC9, 2017-02-21 08:14:40]

Description was changed from

==========
2017-02-21T17:13:25

2017-02-21T17:12:32

BUG=
==========

to

==========
2017-02-21T17:13:25

2017-02-21T17:12:32

BUG=694413
==========

[yosin_UTC9, 2017-02-21 08:14:52]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 08:15:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-02-21 09:07:30]

Description was changed from

==========
2017-02-21T17:13:25

2017-02-21T17:12:32

BUG=694413
==========

to

==========
Add clean layout DCHECK to mostForwardCaretPosition()

This patch adds clean layout |DCHECK()| to |mostForwardCaretPosition()|, and
fixes call sites calling it with dirty layout tree, to make sure we don't call
it with dirty layout tree.

We could not have this |DCHECK()| since we call |mostForwardCaretPosition()|
during node removal, but patch[1] made not to do so.

BUG=694413
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-02-21 09:07:31]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org, xiaochengh@google.com, yoichio@chromium.org

[yosin_UTC9, 2017-02-21 09:08:07]

PTAL

Please click [Commit] if it is OK.

[yosin_UTC9, 2017-02-21 09:09:45]

Description was changed from

==========
Add clean layout DCHECK to mostForwardCaretPosition()

This patch adds clean layout |DCHECK()| to |mostForwardCaretPosition()|, and
fixes call sites calling it with dirty layout tree, to make sure we don't call
it with dirty layout tree.

We could not have this |DCHECK()| since we call |mostForwardCaretPosition()|
during node removal, but patch[1] made not to do so.

BUG=694413
TEST=n/a; no behavior changes
==========

to

==========
Add clean layout DCHECK to mostForwardCaretPosition()

This patch adds clean layout |DCHECK()| to |mostForwardCaretPosition()|, and
fixes call sites calling it with dirty layout tree, to make sure we don't call
it with dirty layout tree.

We could not have this |DCHECK()| since we call |mostForwardCaretPosition()|
during node removal, but patch[1] made not to do so.

There is a similar patch[2].

[1] http://crrev.com/2680943004 Make FrameSelection to hold non-canonicalized
positions
[2] http://crrev.com/2705113003 Add clean layout DCHECK to
mostBackwardCaretPosition()

BUG=694413
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-02-21 09:10:40]

Description was changed from

==========
Add clean layout DCHECK to mostForwardCaretPosition()

This patch adds clean layout |DCHECK()| to |mostForwardCaretPosition()|, and
fixes call sites calling it with dirty layout tree, to make sure we don't call
it with dirty layout tree.

We could not have this |DCHECK()| since we call |mostForwardCaretPosition()|
during node removal, but patch[1] made not to do so.

There is a similar patch[2].

[1] http://crrev.com/2680943004 Make FrameSelection to hold non-canonicalized
positions
[2] http://crrev.com/2705113003 Add clean layout DCHECK to
mostBackwardCaretPosition()

BUG=694413
TEST=n/a; no behavior changes
==========

to

==========
Add clean layout DCHECK to mostForwardCaretPosition()

This patch adds clean layout |DCHECK()| to |mostForwardCaretPosition()|, and
fixes call sites calling it with dirty layout tree, to make sure we don't call
it with dirty layout tree.

We could not have this |DCHECK()| since we call |mostForwardCaretPosition()|
during node removal, but patch[1] made not to do so.

This patch is similar to patch[2].

[1] http://crrev.com/2680943004 Make FrameSelection to hold non-canonicalized
positions
[2] http://crrev.com/2705113003 Add clean layout DCHECK to
mostBackwardCaretPosition()

BUG=694413
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-02-21 09:11:16]

Description was changed from

==========
Add clean layout DCHECK to mostForwardCaretPosition()

This patch adds clean layout |DCHECK()| to |mostForwardCaretPosition()|, and
fixes call sites calling it with dirty layout tree, to make sure we don't call
it with dirty layout tree.

We could not have this |DCHECK()| since we call |mostForwardCaretPosition()|
during node removal, but patch[1] made not to do so.

This patch is similar to patch[2].

[1] http://crrev.com/2680943004 Make FrameSelection to hold non-canonicalized
positions
[2] http://crrev.com/2705113003 Add clean layout DCHECK to
mostBackwardCaretPosition()

BUG=694413
TEST=n/a; no behavior changes
==========

to

==========
Add clean layout DCHECK to mostForwardCaretPosition()

This patch adds clean layout |DCHECK()| to |mostForwardCaretPosition()|, and
fixes call sites calling it with dirty layout tree, to make sure we don't call
it with dirty layout tree.

We could not have this |DCHECK()| since we call |mostForwardCaretPosition()|
during node removal, but patch[1] made not to do so.

This patch is similar to patch[2], which is for |mostBackwardCaretPosition()|.

[1] http://crrev.com/2680943004 Make FrameSelection to hold non-canonicalized
positions
[2] http://crrev.com/2705113003 Add clean layout DCHECK to
mostBackwardCaretPosition()

BUG=694413
TEST=n/a; no behavior changes
==========

[commit-bot: I haz the power, 2017-02-21 11:06:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 11:06:48]

Dry run: This issue passed the CQ dry run.

[tkent, 2017-02-21 22:54:57]

The CQ bit was checked by tkent@chromium.org

[tkent, 2017-02-21 22:54:58]

lgtm

[commit-bot: I haz the power, 2017-02-21 22:56:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 01:30:06]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487717697694940, "parent_rev":
"41f07f2348e5ccec788938057ff29fea5876ff57", "commit_rev":
"22a030be0c75c7a39b938d51d04bcc259bf9fe17"}

[commit-bot: I haz the power, 2017-02-22 01:30:40]

Description was changed from

==========
Add clean layout DCHECK to mostForwardCaretPosition()

This patch adds clean layout |DCHECK()| to |mostForwardCaretPosition()|, and
fixes call sites calling it with dirty layout tree, to make sure we don't call
it with dirty layout tree.

We could not have this |DCHECK()| since we call |mostForwardCaretPosition()|
during node removal, but patch[1] made not to do so.

This patch is similar to patch[2], which is for |mostBackwardCaretPosition()|.

[1] http://crrev.com/2680943004 Make FrameSelection to hold non-canonicalized
positions
[2] http://crrev.com/2705113003 Add clean layout DCHECK to
mostBackwardCaretPosition()

BUG=694413
TEST=n/a; no behavior changes
==========

to

==========
Add clean layout DCHECK to mostForwardCaretPosition()

This patch adds clean layout |DCHECK()| to |mostForwardCaretPosition()|, and
fixes call sites calling it with dirty layout tree, to make sure we don't call
it with dirty layout tree.

We could not have this |DCHECK()| since we call |mostForwardCaretPosition()|
during node removal, but patch[1] made not to do so.

This patch is similar to patch[2], which is for |mostBackwardCaretPosition()|.

[1] http://crrev.com/2680943004 Make FrameSelection to hold non-canonicalized
positions
[2] http://crrev.com/2705113003 Add clean layout DCHECK to
mostBackwardCaretPosition()

BUG=694413
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2706163002
Cr-Commit-Position: refs/heads/master@{#451874}
Committed:
https://chromium.googlesource.com/chromium/src/+/22a030be0c75c7a39b938d51d04b...
==========

[commit-bot: I haz the power, 2017-02-22 01:30:41]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/22a030be0c75c7a39b938d51d04b...