third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp - Issue 2706163002: Add clean layout DCHECK to mostForwardCaretPosition()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp

Issue 2706163002: Add clean layout DCHECK to mostForwardCaretPosition() (Closed)

Patch Set: 2017-02-21T17:13:25 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/VisibleUnits.cpp ('k') | third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp b/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp

index e9feef51b6d4d01d24fbb0d82d2e782175275a74..77d88a15fc56f1fa64f91b7a8e438b8f4c899fd5 100644

--- a/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp

@@ -1386,6 +1386,10 @@ void ApplyStyleCommand::removeInlineStyle(EditingStyle* style,

// FIXME: We should assert that start/end are not in the middle of a text

// node.

+ // TODO(editing-dev): Use of updateStyleAndLayoutIgnorePendingStylesheets

+ // needs to be audited. See http://crbug.com/590369 for more details.

+ document().updateStyleAndLayoutIgnorePendingStylesheets();

Position pushDownStart = mostForwardCaretPosition(start);

// If the pushDownStart is at the end of a text node, then this node is not

// fully selected. Move it to the next deep quivalent position to avoid