Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 2706073003: Revert of headless: Add a dummy include for version.h (Closed)

Created:
3 years, 10 months ago by Sami
Modified:
3 years, 10 months ago
Reviewers:
altimin
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of headless: Add a dummy include for version.h (patchset #1 id:1 of https://codereview.chromium.org/2708643003/ ) Reason for revert: Looks like this isn't needed after all. Original issue's description: > headless: Add a dummy include for version.h > > Add a dummy include for the generated version.h to make sure it will > always be available for users of the headless API. > > BUG=546953 > TBR=altimin@chromium.org > > Review-Url: https://codereview.chromium.org/2708643003 > Cr-Commit-Position: refs/heads/master@{#451595} > Committed: https://chromium.googlesource.com/chromium/src/+/e859ab1300be6e103b62bc5409214e5584287815 TBR=altimin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=546953 Review-Url: https://codereview.chromium.org/2706073003 Cr-Commit-Position: refs/heads/master@{#451620} Committed: https://chromium.googlesource.com/chromium/src/+/e7b3dee936f49e075374368c815c92cb292e73e4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M headless/lib/browser/headless_browser_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Sami
Created Revert of headless: Add a dummy include for version.h
3 years, 10 months ago (2017-02-20 14:19:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2706073003/1
3 years, 10 months ago (2017-02-20 14:19:32 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 14:20:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e7b3dee936f49e075374368c815c...

Powered by Google App Engine
This is Rietveld 408576698