Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2708643003: headless: Add a dummy include for version.h (Closed)

Created:
3 years, 10 months ago by Sami
Modified:
3 years, 10 months ago
Reviewers:
altimin
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

headless: Add a dummy include for version.h Add a dummy include for the generated version.h to make sure it will always be available for users of the headless API. BUG=546953 TBR=altimin@chromium.org Review-Url: https://codereview.chromium.org/2708643003 Cr-Commit-Position: refs/heads/master@{#451595} Committed: https://chromium.googlesource.com/chromium/src/+/e859ab1300be6e103b62bc5409214e5584287815

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M headless/lib/browser/headless_browser_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2708643003/1
3 years, 10 months ago (2017-02-20 10:57:03 UTC) #4
altimin
lgtm
3 years, 10 months ago (2017-02-20 11:02:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/e859ab1300be6e103b62bc5409214e5584287815
3 years, 10 months ago (2017-02-20 11:27:37 UTC) #8
Sami
3 years, 10 months ago (2017-02-20 14:19:20 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2706073003/ by skyostil@chromium.org.

The reason for reverting is: Looks like this isn't needed after all..

Powered by Google App Engine
This is Rietveld 408576698