Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2706043004: [Payments] Add integration test for canceling editor by clicking Android back button (Closed)

Created:
3 years, 10 months ago by gogerald1
Modified:
3 years, 10 months ago
CC:
chromium-reviews, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, gogerald+paymentswatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add integration test for canceling editor by clicking Android back button BUG=693901 Review-Url: https://codereview.chromium.org/2706043004 Cr-Commit-Position: refs/heads/master@{#451862} Committed: https://chromium.googlesource.com/chromium/src/+/c2717e0b70e4fe483cbabf5065cac58c7bc5871a

Patch Set 1 #

Total comments: 6

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -17 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java View 2 chunks +13 lines, -13 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShippingAddressTest.java View 1 3 chunks +50 lines, -4 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java View 1 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
gogerald1
Hi rouslan@, PTAL,
3 years, 10 months ago (2017-02-21 19:15:16 UTC) #4
please use gerrit instead
Thank you for following up :-) https://codereview.chromium.org/2706043004/diff/20001/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShippingAddressTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShippingAddressTest.java (right): https://codereview.chromium.org/2706043004/diff/20001/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShippingAddressTest.java#newcode137 chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShippingAddressTest.java:137: public void testEditShippingAddressAndCancelEditorShouldKeepAddressSelected_2() ...
3 years, 10 months ago (2017-02-21 19:33:08 UTC) #5
gogerald1
Thanks, another look? https://codereview.chromium.org/2706043004/diff/20001/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShippingAddressTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShippingAddressTest.java (right): https://codereview.chromium.org/2706043004/diff/20001/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShippingAddressTest.java#newcode137 chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShippingAddressTest.java:137: public void testEditShippingAddressAndCancelEditorShouldKeepAddressSelected_2() On 2017/02/21 19:33:08, ...
3 years, 10 months ago (2017-02-21 20:44:03 UTC) #8
please use gerrit instead
LGTM!
3 years, 10 months ago (2017-02-21 20:45:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2706043004/80001
3 years, 10 months ago (2017-02-21 23:01:06 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 01:09:20 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/c2717e0b70e4fe483cbabf5065ca...

Powered by Google App Engine
This is Rietveld 408576698