[Payments] Add integration test for canceling editor by clicking Android back button

Add integration test for canceling editor by clicking Android back button

BUG=693901
Review-Url: https://codereview.chromium.org/2706043004
Cr-Commit-Position: refs/heads/master@{#451862}
Committed: https://chromium.googlesource.com/chromium/src/+/c2717e0b70e4fe483cbabf5065cac58c7bc5871a

[gogerald1, 2017-02-21 19:12:15]

Patchset #1 (id:1) has been deleted

[gogerald1, 2017-02-21 19:12:40]

Description was changed from

==========
Add integration test for canceling editor by clicking Android back button

BUG=
==========

to

==========
Add integration test for canceling editor by clicking Android back button

BUG=693901
==========

[gogerald1, 2017-02-21 19:15:15]

gogerald@chromium.org changed reviewers:
+ rouslan@chromium.org

[gogerald1, 2017-02-21 19:15:16]

Hi rouslan@, PTAL,

[please use gerrit instead, 2017-02-21 19:33:08]

Thank you for following up :-)

https://codereview.chromium.org/2706043004/diff/20001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShippingAddressTest.java
(right):

https://codereview.chromium.org/2706043004/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShippingAddressTest.java:137:
public void testEditShippingAddressAndCancelEditorShouldKeepAddressSelected_2()
Let's remove the _1 and _2 suffixes for these methods, because that's not
descriptive. Instead, let's replace the "AndCancelEditor" with
"AndClickAndroidBackButton" in the name of this test case.

https://codereview.chromium.org/2706043004/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShippingAddressTest.java:154:
public void testAddShippingAddressAndCancelEditorShouldKeepAddressSelected()
Let's add the back button equivalent for this test as well.

https://codereview.chromium.org/2706043004/diff/20001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
(right):

https://codereview.chromium.org/2706043004/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java:297:
getInstrumentation().waitForIdleSync();
Why is this line necessary in this method? It's not used in the other helper
methods. I though helper.waitForCallback(callCount) should be sufficient.

[gogerald1, 2017-02-21 20:36:51]

Patchset #2 (id:40001) has been deleted

[gogerald1, 2017-02-21 20:41:56]

Patchset #2 (id:60001) has been deleted

[gogerald1, 2017-02-21 20:44:03]

Thanks, another look?

https://codereview.chromium.org/2706043004/diff/20001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShippingAddressTest.java
(right):

https://codereview.chromium.org/2706043004/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShippingAddressTest.java:137:
public void testEditShippingAddressAndCancelEditorShouldKeepAddressSelected_2()
On 2017/02/21 19:33:08, rouslan wrote:
> Let's remove the _1 and _2 suffixes for these methods, because that's not
> descriptive. Instead, let's replace the "AndCancelEditor" with
> "AndClickAndroidBackButton" in the name of this test case.

Done.

https://codereview.chromium.org/2706043004/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShippingAddressTest.java:154:
public void testAddShippingAddressAndCancelEditorShouldKeepAddressSelected()
On 2017/02/21 19:33:08, rouslan wrote:
> Let's add the back button equivalent for this test as well.

Done.

https://codereview.chromium.org/2706043004/diff/20001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
(right):

https://codereview.chromium.org/2706043004/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java:297:
getInstrumentation().waitForIdleSync();
On 2017/02/21 19:33:08, rouslan wrote:
> Why is this line necessary in this method? It's not used in the other helper
> methods. I though helper.waitForCallback(callCount) should be sufficient.

Done.

[gogerald1, 2017-02-21 20:44:39]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[please use gerrit instead, 2017-02-21 20:45:47]

LGTM!

[commit-bot: I haz the power, 2017-02-21 20:46:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 22:48:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 22:48:53]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[gogerald1, 2017-02-21 22:59:41]

The CQ bit was checked by gogerald@chromium.org

[commit-bot: I haz the power, 2017-02-21 23:01:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 01:07:29]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1487717981546930,
"parent_rev": "8a0be9febc6a33b487eaade15f7ec08cdd5e6b0d", "commit_rev":
"c2717e0b70e4fe483cbabf5065cac58c7bc5871a"}

[commit-bot: I haz the power, 2017-02-22 01:09:19]

Description was changed from

==========
Add integration test for canceling editor by clicking Android back button

BUG=693901
==========

to

==========
Add integration test for canceling editor by clicking Android back button

BUG=693901

Review-Url: https://codereview.chromium.org/2706043004
Cr-Commit-Position: refs/heads/master@{#451862}
Committed:
https://chromium.googlesource.com/chromium/src/+/c2717e0b70e4fe483cbabf5065ca...
==========

[commit-bot: I haz the power, 2017-02-22 01:09:20]

Committed patchset #2 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/c2717e0b70e4fe483cbabf5065ca...