Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2363)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java

Issue 2706043004: [Payments] Add integration test for canceling editor by clicking Android back button (Closed)
Patch Set: address comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShippingAddressTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java
index 5bafea6b98122b9f14353a0e4cf6c5b4a6056c1e..75f294b70c1a0410b4206c77aee796eca252a7c9 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java
@@ -372,6 +372,19 @@ public class EditorView extends AlwaysDismissedDialog implements OnClickListener
mDataView.addView(mFooter);
}
+ private void removeTextChangedListenersAndInputFilters() {
+ if (mCardInput != null) {
+ mCardInput.removeTextChangedListener(mCardNumberFormatter);
+ mCardInput.setFilters(new InputFilter[0]); // Null is not allowed.
+ mCardInput = null;
+ }
+
+ if (mPhoneInput != null) {
+ mPhoneInput.removeTextChangedListener(mPhoneFormatter);
+ mPhoneInput = null;
+ }
+ }
+
private View addFieldViewToEditor(ViewGroup parent, final EditorFieldModel fieldModel) {
View childView = null;
@@ -524,19 +537,6 @@ public class EditorView extends AlwaysDismissedDialog implements OnClickListener
}
}
- private void removeTextChangedListenersAndInputFilters() {
- if (mCardInput != null) {
- mCardInput.removeTextChangedListener(mCardNumberFormatter);
- mCardInput.setFilters(new InputFilter[0]); // Null is not allowed.
- mCardInput = null;
- }
-
- if (mPhoneInput != null) {
- mPhoneInput.removeTextChangedListener(mPhoneFormatter);
- mPhoneInput = null;
- }
- }
-
private List<EditorFieldView> getViewsWithInvalidInformation(boolean findAll) {
List<EditorFieldView> invalidViews = new ArrayList<>();
for (int i = 0; i < mFieldViews.size(); i++) {
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShippingAddressTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698