Don't throw when getting selection(Direction|Start|End) on input

Don't throw when getting selection(Direction|Start|End) on input

Return null instead of throwing |InvalidStateError| for visiting
|selectionDirection|, |selectionStart| and |selectionEnd| on |input|
which does not apply selection API.

Firefox has the similar behavior.

Spec: https://html.spec.whatwg.org/multipage/forms.html#dom-textarea/input-selectionstart

This change fix 25 fails in layout tests.

BUG=622679
Review-Url: https://codereview.chromium.org/2706033004
Cr-Commit-Position: refs/heads/master@{#451926}
Committed: https://chromium.googlesource.com/chromium/src/+/fa9836f9a52257a725282c2d12f9a4d213cd0109

[Sunny, 2017-02-20 17:36:47]

ratsunny@gmail.com changed reviewers:
+ tkent@chromium.org

[Sunny, 2017-02-20 17:36:47]

Hi tkent@, please take a look, thanks :D

[tkent, 2017-02-20 19:52:17]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 19:52:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 20:55:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 20:55:24]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[tkent, 2017-02-20 23:43:07]

https://codereview.chromium.org/2706033004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/textfieldselection/selection-not-application-expected.txt
(right):

https://codereview.chromium.org/2706033004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/textfieldselection/selection-not-application-expected.txt:2:
FAIL text field selection for the input hidden assert_throws: function "function
(){
The test selection-not-application.html is inconsistent with the current
specification.  We should update the test.
You can change selection-not-application.html in this CL, and our WPT exporter
will merge the change to web-platform-tests in GitHub.

[Sunny, 2017-02-21 12:36:50]

Description was changed from

==========
Don't throw when getting selection(Direction|Start|End) on input

Return null instead of throwing |InvalidStateError| for visiting
|selectionDirection|, |selectionStart| and |selectionEnd| on |input|
which does not apply selection API.

Firefox has the similar behavior.

Spec:
https://html.spec.whatwg.org/multipage/forms.html#dom-textarea/input-selectio...

This change fix 25 fails in layout tests but breaks 17 tests passed
before. The break is caused by bugs in test but not this change.

BUG=622679
==========

to

==========
Don't throw when getting selection(Direction|Start|End) on input

Return null instead of throwing |InvalidStateError| for visiting
|selectionDirection|, |selectionStart| and |selectionEnd| on |input|
which does not apply selection API.

Firefox has the similar behavior.

Spec:
https://html.spec.whatwg.org/multipage/forms.html#dom-textarea/input-selectio...

This change fix 25 fails in layout tests.

BUG=622679
==========

[Sunny, 2017-02-21 12:41:49]

On 2017/02/20 23:43:07, tkent wrote:
>
https://codereview.chromium.org/2706033004/diff/1/third_party/WebKit/LayoutTe...
> File
>
third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/textfieldselection/selection-not-application-expected.txt
> (right):
> 
>
https://codereview.chromium.org/2706033004/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/textfieldselection/selection-not-application-expected.txt:2:
> FAIL text field selection for the input hidden assert_throws: function
"function
> (){
> The test selection-not-application.html is inconsistent with the current
> specification.  We should update the test.
> You can change selection-not-application.html in this CL, and our WPT exporter
> will merge the change to web-platform-tests in GitHub.

Hi tkent@, happy to know chromium have a WPT exporter. I've updated CL and
please take a look, thanks!

[tkent, 2017-02-21 21:19:23]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 21:21:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 23:25:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 23:25:57]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[tkent, 2017-02-22 00:09:43]

The CQ bit was checked by tkent@chromium.org

[tkent, 2017-02-22 00:09:44]

lgtm

[commit-bot: I haz the power, 2017-02-22 00:11:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 02:14:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 02:14:33]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[tkent, 2017-02-22 02:15:27]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2017-02-22 02:16:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 04:20:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 04:20:08]

Exceeded global retry quota

[tkent, 2017-02-22 06:08:17]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2017-02-22 06:09:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 06:21:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 06:21:46]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tkent, 2017-02-22 06:22:56]

tkent@chromium.org changed reviewers:
+ ericwilligers@chromium.org, haraken@chromium.org

[tkent, 2017-02-22 06:23:26]

ericwilligers@ or haraken@, please approve histograms.xml

[haraken, 2017-02-22 06:42:38]

LGTM

[tkent, 2017-02-22 06:54:43]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2017-02-22 06:55:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 08:21:20]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487746483592530,
"parent_rev": "cf490d43d2b0e49ff06958cba34c502db192717d", "commit_rev":
"fa9836f9a52257a725282c2d12f9a4d213cd0109"}

[commit-bot: I haz the power, 2017-02-22 08:21:57]

Description was changed from

==========
Don't throw when getting selection(Direction|Start|End) on input

Return null instead of throwing |InvalidStateError| for visiting
|selectionDirection|, |selectionStart| and |selectionEnd| on |input|
which does not apply selection API.

Firefox has the similar behavior.

Spec:
https://html.spec.whatwg.org/multipage/forms.html#dom-textarea/input-selectio...

This change fix 25 fails in layout tests.

BUG=622679
==========

to

==========
Don't throw when getting selection(Direction|Start|End) on input

Return null instead of throwing |InvalidStateError| for visiting
|selectionDirection|, |selectionStart| and |selectionEnd| on |input|
which does not apply selection API.

Firefox has the similar behavior.

Spec:
https://html.spec.whatwg.org/multipage/forms.html#dom-textarea/input-selectio...

This change fix 25 fails in layout tests.

BUG=622679

Review-Url: https://codereview.chromium.org/2706033004
Cr-Commit-Position: refs/heads/master@{#451926}
Committed:
https://chromium.googlesource.com/chromium/src/+/fa9836f9a52257a725282c2d12f9...
==========

[commit-bot: I haz the power, 2017-02-22 08:21:59]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fa9836f9a52257a725282c2d12f9...