third_party/WebKit/Source/core/html/HTMLInputElement.h - Issue 2706033004: Don't throw when getting selection(Direction|Start|End) on input

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLInputElement.h

Issue 2706033004: Don't throw when getting selection(Direction|Start|End) on input (Closed)

Patch Set: Refine test Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLInputElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLInputElement.h b/third_party/WebKit/Source/core/html/HTMLInputElement.h

index 03d37aa63b9ffd05eb4fd05580d20e69739066a7..5ca9a35360618f8be718de98a015d6dda64d9481 100644

--- a/third_party/WebKit/Source/core/html/HTMLInputElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLInputElement.h

@@ -156,8 +156,8 @@ class CORE_EXPORT HTMLInputElement : public TextControlElement {

// delay the 'input' event with EventQueueScope.

void setValueFromRenderer(const String&);

- unsigned selectionStartForBinding(ExceptionState&) const;

- unsigned selectionEndForBinding(ExceptionState&) const;

+ unsigned selectionStartForBinding(bool&, ExceptionState&) const;

+ unsigned selectionEndForBinding(bool&, ExceptionState&) const;

String selectionDirectionForBinding(ExceptionState&) const;

void setSelectionStartForBinding(unsigned, ExceptionState&);

void setSelectionEndForBinding(unsigned, ExceptionState&);