Expand FrameSeleciton::getSelectionType() to increase chances of hoisting update layout

Expand FrameSeleciton::getSelectionType() to increase chances of hoisting update layout

This patch expands |FrameSeleciton::getSelectionType()| to increase
chance of hoisting update layout.

Note: This is mechanical change to replace |selection().getSelectionType()|
by |selection().computeVisibleSelectionInDOMTreeDeprecated().getSelectionType()|
Following patch will remove deprecated version.

This patch is apart of expanding expensive member functions in |FrameSelection|:
- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- getSelectionType()
- base() 
- extent()
- start()
- end()
- isNone() 
- isCaret()
- isRange()

BUG=694360
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2706013005
Cr-Commit-Position: refs/heads/master@{#452030}
Committed: https://chromium.googlesource.com/chromium/src/+/82b855c5f7d20fc8a8b5bcb4a61f17e3fde257de

[yosin_UTC9, 2017-02-22 03:36:22]

Description was changed from

==========
2017-02-22T12:34:17

2017-02-22T12:32:58

BUG=
==========

to

==========
Expand FrameSeleciton::getSelectionType() to increase chances of hoisting update
layout

This patch expands |FrameSeleciton::getSelectionType()| to increase
chance of hoisting update layout.

Note: This is mechanical change to replace |selection().getSelectionType()|
by |selection().computeVisibleSelectionInDOMTreeDeprecated().getSelectionType()|
Following patch will remove deprecated version.

This patch is apart of expanding expensive member functions in |FrameSelection|:
- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- getSelectionType()
- base() 
- extent()
- start()
- end()
- isNone() 
- isCaret()
- isRange()

BUG=694360
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-02-22 03:36:29]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 03:37:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-02-22 06:53:22]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-02-22 06:53:23]

PTAL

Changes in core/editing/ and core/svg/

[tkent, 2017-02-22 07:35:23]

lgtm

[yosin_UTC9, 2017-02-22 07:36:02]

The CQ bit was unchecked by yosin@chromium.org

[yosin_UTC9, 2017-02-22 07:36:03]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-02-22 07:36:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 10:51:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 10:51:52]

Failed to apply patch for
third_party/WebKit/Source/core/svg/UnsafeSVGAttributeSanitizationTest.cpp:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/Source/core/svg/UnsafeSVGAttributeSanitizationTest.cpp:60
  error:
third_party/WebKit/Source/core/svg/UnsafeSVGAttributeSanitizationTest.cpp: patch
does not apply

Patch:      
third_party/WebKit/Source/core/svg/UnsafeSVGAttributeSanitizationTest.cpp
Index: third_party/WebKit/Source/core/svg/UnsafeSVGAttributeSanitizationTest.cpp
diff --git
a/third_party/WebKit/Source/core/svg/UnsafeSVGAttributeSanitizationTest.cpp
b/third_party/WebKit/Source/core/svg/UnsafeSVGAttributeSanitizationTest.cpp
index
d2c68ce96358e2d9cf4f75020e578722e52848c3..539d447744fa1eaca7f088406d4962df725a932e
100644
--- a/third_party/WebKit/Source/core/svg/UnsafeSVGAttributeSanitizationTest.cpp
+++ b/third_party/WebKit/Source/core/svg/UnsafeSVGAttributeSanitizationTest.cpp
@@ -60,7 +60,9 @@ String contentAfterPastingHTML(DummyPageHolder* pageHolder,
   frame.document()->updateStyleAndLayout();
   frame.selection().setSelection(
       SelectionInDOMTree::Builder().selectAllChildren(*body).build());
-  EXPECT_EQ(CaretSelection, frame.selection().getSelectionType());
+  EXPECT_EQ(CaretSelection, frame.selection()
+                                .computeVisibleSelectionInDOMTreeDeprecated()
+                                .getSelectionType());
   EXPECT_TRUE(frame.selection().isContentEditable())
       << "We should be pasting into something editable.";

[yosin_UTC9, 2017-02-22 12:27:43]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-02-22 12:27:43]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/2706013005/#ps20001
(title: "2017-02-22T21:26:37 rebase")

[commit-bot: I haz the power, 2017-02-22 12:28:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 14:07:59]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487766463574320,
"parent_rev": "be42343c9fd8b9fbb5733faf2e93abc3ff648b7f", "commit_rev":
"82b855c5f7d20fc8a8b5bcb4a61f17e3fde257de"}

[commit-bot: I haz the power, 2017-02-22 14:08:36]

Description was changed from

==========
Expand FrameSeleciton::getSelectionType() to increase chances of hoisting update
layout

This patch expands |FrameSeleciton::getSelectionType()| to increase
chance of hoisting update layout.

Note: This is mechanical change to replace |selection().getSelectionType()|
by |selection().computeVisibleSelectionInDOMTreeDeprecated().getSelectionType()|
Following patch will remove deprecated version.

This patch is apart of expanding expensive member functions in |FrameSelection|:
- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- getSelectionType()
- base() 
- extent()
- start()
- end()
- isNone() 
- isCaret()
- isRange()

BUG=694360
TEST=n/a; no behavior changes
==========

to

==========
Expand FrameSeleciton::getSelectionType() to increase chances of hoisting update
layout

This patch expands |FrameSeleciton::getSelectionType()| to increase
chance of hoisting update layout.

Note: This is mechanical change to replace |selection().getSelectionType()|
by |selection().computeVisibleSelectionInDOMTreeDeprecated().getSelectionType()|
Following patch will remove deprecated version.

This patch is apart of expanding expensive member functions in |FrameSelection|:
- rootEditableElement()
- hasEditableStyle()
- isContentEditable()
- isContentRichlyEditable()
- getSelectionType()
- base() 
- extent()
- start()
- end()
- isNone() 
- isCaret()
- isRange()

BUG=694360
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2706013005
Cr-Commit-Position: refs/heads/master@{#452030}
Committed:
https://chromium.googlesource.com/chromium/src/+/82b855c5f7d20fc8a8b5bcb4a61f...
==========

[commit-bot: I haz the power, 2017-02-22 14:08:37]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/82b855c5f7d20fc8a8b5bcb4a61f...