Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: third_party/WebKit/Source/core/editing/FrameSelection.h

Issue 2706013005: Expand FrameSeleciton::getSelectionType() to increase chances of hoisting update layout (Closed)
Patch Set: 2017-02-22T21:26:37 rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 FrameSelection::SetSelectionOptions = CloseTyping | ClearTypingStyle); 151 FrameSelection::SetSelectionOptions = CloseTyping | ClearTypingStyle);
152 void selectAll(); 152 void selectAll();
153 void clear(); 153 void clear();
154 154
155 // Call this after doing user-triggered selections to make it easy to delete 155 // Call this after doing user-triggered selections to make it easy to delete
156 // the frame you entirely selected. 156 // the frame you entirely selected.
157 void selectFrameElementInParentIfFullySelected(); 157 void selectFrameElementInParentIfFullySelected();
158 158
159 bool contains(const LayoutPoint&); 159 bool contains(const LayoutPoint&);
160 160
161 SelectionType getSelectionType() const {
162 return computeVisibleSelectionInDOMTreeDeprecated().getSelectionType();
163 }
164
165 bool modify(EAlteration, 161 bool modify(EAlteration,
166 SelectionDirection, 162 SelectionDirection,
167 TextGranularity, 163 TextGranularity,
168 EUserTriggered = NotUserTriggered); 164 EUserTriggered = NotUserTriggered);
169 enum VerticalDirection { DirectionUp, DirectionDown }; 165 enum VerticalDirection { DirectionUp, DirectionDown };
170 bool modify(EAlteration, unsigned verticalDistance, VerticalDirection); 166 bool modify(EAlteration, unsigned verticalDistance, VerticalDirection);
171 167
172 // Moves the selection extent based on the selection granularity strategy. 168 // Moves the selection extent based on the selection granularity strategy.
173 // This function does not allow the selection to collapse. If the new 169 // This function does not allow the selection to collapse. If the new
174 // extent is resolved to the same position as the current base, this 170 // extent is resolved to the same position as the current base, this
(...skipping 165 matching lines...) Expand 10 before | Expand all | Expand 10 after
340 336
341 } // namespace blink 337 } // namespace blink
342 338
343 #ifndef NDEBUG 339 #ifndef NDEBUG
344 // Outside the WebCore namespace for ease of invocation from gdb. 340 // Outside the WebCore namespace for ease of invocation from gdb.
345 void showTree(const blink::FrameSelection&); 341 void showTree(const blink::FrameSelection&);
346 void showTree(const blink::FrameSelection*); 342 void showTree(const blink::FrameSelection*);
347 #endif 343 #endif
348 344
349 #endif // FrameSelection_h 345 #endif // FrameSelection_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/editing/Editor.cpp ('k') | third_party/WebKit/Source/core/editing/FrameSelection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698