Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2705803002:
chromeos oobe: onNetworkConnected_ is not a function (Closed)
|
Created:
3 years, 10 months ago by Alexander Alekseev Modified:
3 years, 10 months ago Reviewers:
stevenjb CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionchromeos oobe: onNetworkConnected_ is not a function
Remove onNetworkConnected_ call as network item will trigger "connected"
event itself.
BUG=692797
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2705803002
Cr-Commit-Position: refs/heads/master@{#451927}
Committed: https://chromium.googlesource.com/chromium/src/+/896435ba0b632e5e04c0fa83158ca275f09feb1b
Patch Set 1 #
Total comments: 2
Patch Set 2 : Rebased. #Patch Set 3 : Update after review. #Messages
Total messages: 23 (16 generated)
Description was changed from ========== chromeos oobe: onNetworkConnected_ is not a function Remove onNetworkConnected_ call as network item will trigger "connected" event itself. BUG=692797 ========== to ========== chromeos oobe: onNetworkConnected_ is not a function Remove onNetworkConnected_ call as network item will trigger "connected" event itself. BUG=692797 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
alemate@chromium.org changed reviewers: + stevenjb@chromium.org
Please review.
The CQ bit was checked by alemate@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2705803002/diff/1/chrome/browser/resources/ch... File chrome/browser/resources/chromeos/login/oobe_welcome.js (right): https://codereview.chromium.org/2705803002/diff/1/chrome/browser/resources/ch... chrome/browser/resources/chromeos/login/oobe_welcome.js:349: if (lastError.message == 'connected') nit: This could now be == 'connected' || == 'connecting' (and remove the if at line 352)
https://codereview.chromium.org/2705803002/diff/1/chrome/browser/resources/ch... File chrome/browser/resources/chromeos/login/oobe_welcome.js (right): https://codereview.chromium.org/2705803002/diff/1/chrome/browser/resources/ch... chrome/browser/resources/chromeos/login/oobe_welcome.js:349: if (lastError.message == 'connected') On 2017/02/21 17:54:41, stevenjb wrote: > nit: This could now be == 'connected' || == 'connecting' (and remove the if at > line 352) Done.
The CQ bit was checked by alemate@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from stevenjb@chromium.org Link to the patchset: https://codereview.chromium.org/2705803002/#ps40001 (title: "Update after review.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) closure_compilation on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by alemate@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by alemate@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487732567310420,
"parent_rev": "fa9836f9a52257a725282c2d12f9a4d213cd0109", "commit_rev":
"896435ba0b632e5e04c0fa83158ca275f09feb1b"}
Message was sent while issue was closed.
Description was changed from ========== chromeos oobe: onNetworkConnected_ is not a function Remove onNetworkConnected_ call as network item will trigger "connected" event itself. BUG=692797 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== chromeos oobe: onNetworkConnected_ is not a function Remove onNetworkConnected_ call as network item will trigger "connected" event itself. BUG=692797 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2705803002 Cr-Commit-Position: refs/heads/master@{#451927} Committed: https://chromium.googlesource.com/chromium/src/+/896435ba0b632e5e04c0fa83158c... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/896435ba0b632e5e04c0fa83158c... |
