Fix WebVR getDevices promise not resolving when VR Services are not compatible.

Fix WebVR getDevices promise not resolving when VR Services are not compatible.

Adds a check for initialization before GvrDeviceProvider adds a device.

Adding a device without the library in place (succesful initialization) makes the promise hang waiting for a device connected event which never happens.

BUG=693298
Review-Url: https://codereview.chromium.org/2705653005
Cr-Commit-Position: refs/heads/master@{#451847}
Committed: https://chromium.googlesource.com/chromium/src/+/dd47ba396451348cc15ecbc53255cb618e457414

[amp, 2017-02-17 22:29:34]

amp@chromium.org changed reviewers:
+ bajones@chromium.org, mthiesse@chromium.org

[amp, 2017-02-17 22:29:34]

I'm not sure if this is the best way to do this, but it resolves the promise
correctly when VrCore is out of date.

[bajones, 2017-02-17 22:59:47]

On 2017/02/17 22:29:34, amp wrote:
> I'm not sure if this is the best way to do this, but it resolves the promise
> correctly when VrCore is out of date.

LGTM. I can't imagine that we'd want to advertise a device when initialization
fails.

[amp, 2017-02-17 23:08:41]

On 2017/02/17 22:59:47, bajones wrote:
> On 2017/02/17 22:29:34, amp wrote:
> > I'm not sure if this is the best way to do this, but it resolves the promise
> > correctly when VrCore is out of date.
> 
> LGTM. I can't imagine that we'd want to advertise a device when initialization
> fails.

Yea, I just wasn't sure if checking initialized_ directly was preferable (vs
having Initialized return a boolean or something).

I'm not familiar enough with c++ style to know either way.

[amp, 2017-02-17 23:33:42]

The CQ bit was checked by amp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 23:34:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[amp, 2017-02-17 23:49:40]

The CQ bit was unchecked by amp@chromium.org

[amp, 2017-02-17 23:49:44]

The CQ bit was checked by amp@chromium.org

[commit-bot: I haz the power, 2017-02-17 23:51:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 01:39:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 01:39:23]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[mthiesse, 2017-02-18 21:14:49]

LGTM, thanks!

[amp, 2017-02-21 18:48:41]

The CQ bit was checked by amp@chromium.org

[amp, 2017-02-21 18:48:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
mthiesse@chromium.org, bajones@chromium.org
Link to the patchset: https://codereview.chromium.org/2705653005/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2017-02-21 18:50:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 20:54:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 20:54:19]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[amp, 2017-02-21 20:55:25]

The CQ bit was checked by amp@chromium.org

[commit-bot: I haz the power, 2017-02-21 20:56:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 22:10:26]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487710525424240,
"parent_rev": "f2446f652488f56771631375ee11d2396de248e7", "commit_rev":
"dd47ba396451348cc15ecbc53255cb618e457414"}

[commit-bot: I haz the power, 2017-02-21 22:11:04]

Description was changed from

==========
Fix WebVR getDevices promise not resolving when VR Services are not compatible.

Adds a check for initialization before GvrDeviceProvider adds a device.

Adding a device without the library in place (succesful initialization) makes
the promise hang waiting for a device connected event which never happens.

BUG=693298
==========

to

==========
Fix WebVR getDevices promise not resolving when VR Services are not compatible.

Adds a check for initialization before GvrDeviceProvider adds a device.

Adding a device without the library in place (succesful initialization) makes
the promise hang waiting for a device connected event which never happens.

BUG=693298

Review-Url: https://codereview.chromium.org/2705653005
Cr-Commit-Position: refs/heads/master@{#451847}
Committed:
https://chromium.googlesource.com/chromium/src/+/dd47ba396451348cc15ecbc53255...
==========

[commit-bot: I haz the power, 2017-02-21 22:11:05]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dd47ba396451348cc15ecbc53255...