device/vr/android/gvr/gvr_device_provider.cc - Issue 2705653005: Fix WebVR getDevices promise not resolving when VR Services are not compatible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/vr/android/gvr/gvr_device_provider.cc

Issue 2705653005: Fix WebVR getDevices promise not resolving when VR Services are not compatible. (Closed)

Patch Set: rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: device/vr/android/gvr/gvr_device_provider.cc

diff --git a/device/vr/android/gvr/gvr_device_provider.cc b/device/vr/android/gvr/gvr_device_provider.cc

index 971fd7fcb9156864949e52b9379a2a5a7dee3e2d..4aff6ce54860890f749df2ec638836a32b48f671 100644

--- a/device/vr/android/gvr/gvr_device_provider.cc

+++ b/device/vr/android/gvr/gvr_device_provider.cc

@@ -34,7 +34,8 @@ GvrDeviceProvider::~GvrDeviceProvider() {

void GvrDeviceProvider::GetDevices(std::vector<VRDevice*>* devices) {

Initialize();

- devices->push_back(vr_device_.get());

+ if (initialized_)

+ devices->push_back(vr_device_.get());

}

void GvrDeviceProvider::Initialize() {

« no previous file with comments | « no previous file | no next file » | no next file with comments »