Fix various nits in VM patch files.

Fix various nits in VM patch files.

R=vegorov@google.com

Committed: https://github.com/dart-lang/sdk/commit/00bed94e0c34bb05da89a5d776cc5da6636d921b

[ahe, 2017-02-17 12:48:30]

Patchset #1 (id:1) has been deleted

[ahe, 2017-02-17 12:50:23]

ahe@google.com changed reviewers:
+ vegorov@google.com

[ahe, 2017-02-17 12:50:25]

Making progress with patch files, and got tired of looking at nits (aka lint
warnings) reported by fasta.

[Vyacheslav Egorov (Google), 2017-02-17 13:08:52]

lgtm

https://codereview.chromium.org/2705593002/diff/20001/runtime/lib/math_patch....
File runtime/lib/math_patch.dart (right):

https://codereview.chromium.org/2705593002/diff/20001/runtime/lib/math_patch....
runtime/lib/math_patch.dart:102: final _state;
Uint32List _state

https://codereview.chromium.org/2705593002/diff/20001/sdk/lib/io/secure_socke...
File sdk/lib/io/secure_socket.dart (left):

https://codereview.chromium.org/2705593002/diff/20001/sdk/lib/io/secure_socke...
sdk/lib/io/secure_socket.dart:454: this.onBadCertificate(X509Certificate
certificate),
This was a more specific signature then onBadCertificate own type. Maybe own
type needs to be fixed?

[ahe, 2017-02-17 13:38:28]

PTAL

https://codereview.chromium.org/2705593002/diff/20001/runtime/lib/math_patch....
File runtime/lib/math_patch.dart (right):

https://codereview.chromium.org/2705593002/diff/20001/runtime/lib/math_patch....
runtime/lib/math_patch.dart:102: final _state;
On 2017/02/17 13:08:52, Vyacheslav Egorov (Google) wrote:
> Uint32List _state

Done.

https://codereview.chromium.org/2705593002/diff/20001/sdk/lib/io/secure_socke...
File sdk/lib/io/secure_socket.dart (left):

https://codereview.chromium.org/2705593002/diff/20001/sdk/lib/io/secure_socke...
sdk/lib/io/secure_socket.dart:454: this.onBadCertificate(X509Certificate
certificate),
On 2017/02/17 13:08:52, Vyacheslav Egorov (Google) wrote:
> This was a more specific signature then onBadCertificate own type. Maybe own
> type needs to be fixed?

I'm comfortable removing type annotations from Dart code, but adding types can
have unintended side-effects that I'd rather avoid. So honestly, I'd rather not
change the type on the field.

That being said, I don't think it's necessary. This constructor is private, and
the connect method has the proper signature.

[Vyacheslav Egorov (Google), 2017-02-17 13:42:56]

lgtm

[ahe, 2017-02-17 15:29:04]

Description was changed from

==========
Fix various nits in VM patch files.
==========

to

==========
Fix various nits in VM patch files.

R=vegorov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/00bed94e0c34bb05da89a5d776cc5da6636d921b
==========

[ahe, 2017-02-17 15:29:05]

Committed patchset #2 (id:40001) manually as
00bed94e0c34bb05da89a5d776cc5da6636d921b (presubmit successful).