runtime/bin/socket_patch.dart - Issue 2705593002: Fix various nits in VM patch files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/socket_patch.dart

Issue 2705593002: Fix various nits in VM patch files. (Closed)

Patch Set: Address comments and issues found during testing. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/socket_patch.dart

diff --git a/runtime/bin/socket_patch.dart b/runtime/bin/socket_patch.dart

index c11cec115ea13aa884322aaadfdb1fbf51bc6cbf..3b81e083035b4d47910ce364e5e809bec37c7089 100644

--- a/runtime/bin/socket_patch.dart

+++ b/runtime/bin/socket_patch.dart

@@ -144,9 +144,7 @@ class _InternetAddress implements InternetAddress {

Future<InternetAddress> reverse() => _NativeSocket.reverseLookup(this);

- _InternetAddress(String this.address,

- String this._host,

- List<int> this._in_addr);

+ _InternetAddress(this.address, this._host, this._in_addr);

factory _InternetAddress.parse(String address) {

if (address is !String) {

@@ -1527,7 +1525,7 @@ class _Socket extends Stream<List<int>> implements Socket {

var _subscription;

var _detachReady;

- _Socket(RawSocket this._raw) {

+ _Socket(this._raw) {

_controller = new StreamController<List<int>>(sync: true,

onListen: _onSubscriptionStateChange,

onCancel: _onSubscriptionStateChange,

« no previous file with comments | « runtime/bin/process_patch.dart ('k') | runtime/lib/async_patch.dart » ('j') | no next file with comments »