Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Side by Side Diff: runtime/lib/async_patch.dart

Issue 2705593002: Fix various nits in VM patch files. (Closed)
Patch Set: Address comments and issues found during testing. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/bin/socket_patch.dart ('k') | runtime/lib/bigint.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import "dart:_internal"; 5 import "dart:_internal" hide Symbol;
6 6
7 // We need to pass the value as first argument and leave the second and third 7 // We need to pass the value as first argument and leave the second and third
8 // arguments empty (used for error handling). 8 // arguments empty (used for error handling).
9 // See vm/ast_transformer.cc for usage. 9 // See vm/ast_transformer.cc for usage.
10 Function _asyncThenWrapperHelper(continuation) { 10 Function _asyncThenWrapperHelper(continuation) {
11 // Any function that is used as an asynchronous callback must be registered 11 // Any function that is used as an asynchronous callback must be registered
12 // in the current Zone. Normally, this is done by the future when a 12 // in the current Zone. Normally, this is done by the future when a
13 // callback is registered (for example with `.then` or `.catchError`). In our 13 // callback is registered (for example with `.then` or `.catchError`). In our
14 // case we want to reuse the same callback multiple times and therefore avoid 14 // case we want to reuse the same callback multiple times and therefore avoid
15 // the multiple registrations. For our internal futures (`_Future`) we can 15 // the multiple registrations. For our internal futures (`_Future`) we can
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
194 194
195 /// Returns a [StackTrace] object containing the synchronous prefix for this 195 /// Returns a [StackTrace] object containing the synchronous prefix for this
196 /// asynchronous method. 196 /// asynchronous method.
197 Object _asyncStackTraceHelper() native "StackTrace_asyncStackTraceHelper"; 197 Object _asyncStackTraceHelper() native "StackTrace_asyncStackTraceHelper";
198 198
199 void _clearAsyncThreadStackTrace() 199 void _clearAsyncThreadStackTrace()
200 native "StackTrace_clearAsyncThreadStackTrace"; 200 native "StackTrace_clearAsyncThreadStackTrace";
201 201
202 void _setAsyncThreadStackTrace(StackTrace stackTrace) native 202 void _setAsyncThreadStackTrace(StackTrace stackTrace) native
203 "StackTrace_setAsyncThreadStackTrace"; 203 "StackTrace_setAsyncThreadStackTrace";
OLDNEW
« no previous file with comments | « runtime/bin/socket_patch.dart ('k') | runtime/lib/bigint.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698