Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2705503002: Mojo C++ bindings: rename GetIsolatedProxy to MakeIsolatedRequest to better match other functions. (Closed)

Created:
3 years, 10 months ago by yzshen1
Modified:
3 years, 9 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, cmumford, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, David Black, donnd+watch_chromium.org, jam, Jered, jfweitz+watch_chromium.org, jsbell+idb_chromium.org, kmadhusu+watch_chromium.org, melevin+watch_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-screen-orientation_chromium.org, nasko+codewatch_chromium.org, qsr+mojo_chromium.org, samarth+watch_chromium.org, skanuj+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: rename GetIsolatedProxy to MakeIsolatedRequest to better match other functions. This CL also removes MakeRequestForTesting. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2705503002 Cr-Commit-Position: refs/heads/master@{#457994} Committed: https://chromium.googlesource.com/chromium/src/+/72bee950f8c8223616e0f30316dc792e93553438

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -21 lines) Patch
M chrome/browser/ui/search/search_ipc_router.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/dom_storage/local_storage_context_mojo.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/child/indexed_db/webidbcursor_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/associated_interface_provider_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/mock_render_process_host.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/screen_orientation/screen_orientation_dispatcher_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/associated_interface_ptr.h View 3 chunks +4 lines, -14 lines 0 comments Download

Messages

Total messages: 22 (14 generated)
yzshen1
Hi, Jochen. Would you please take a look at this CL? This is a simple ...
3 years, 10 months ago (2017-02-16 22:12:41 UTC) #5
jochen (gone - plz use gerrit)
lgtm
3 years, 10 months ago (2017-02-20 09:53:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705503002/1
3 years, 10 months ago (2017-02-20 16:13:55 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/314435)
3 years, 10 months ago (2017-02-20 17:32:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705503002/1
3 years, 9 months ago (2017-03-10 22:33:11 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/170663) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 9 months ago (2017-03-10 22:36:08 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705503002/20001
3 years, 9 months ago (2017-03-19 06:03:56 UTC) #19
commit-bot: I haz the power
3 years, 9 months ago (2017-03-19 07:52:19 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/72bee950f8c8223616e0f30316dc...

Powered by Google App Engine
This is Rietveld 408576698