Mojo C++ bindings: rename GetIsolatedProxy to MakeIsolatedRequest to better match other functions.

mojo/public/cpp/bindings/associated_interface_ptr.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MOJO_PUBLIC_CPP_BINDINGS_ASSOCIATED_INTERFACE_PTR_H_
 #define MOJO_PUBLIC_CPP_BINDINGS_ASSOCIATED_INTERFACE_PTR_H_
 
 #include <stdint.h>
 
 #include <string>
@@ skipping 214 matching lines @@
                                                               &handle1);
 
   ptr_info->set_handle(std::move(handle0));
   ptr_info->set_version(0);
 
   AssociatedInterfaceRequest<Interface> request;
   request.Bind(std::move(handle1));
   return request;
 }
 
-// Like |GetProxy|, but the interface is never associated with any other
-// interface. The returned request can be bound directly to the corresponding
-// associated interface implementation, without first passing it through a
-// message pipe endpoint.
+// Like MakeRequest() above, but it creates a dedicated message pipe. The
+// returned request can be bound directly to an implementation, without being
+// first passed through a message pipe endpoint.
 //
 // This function has two main uses:
 //
 //  * In testing, where the returned request is bound to e.g. a mock and there
 //    are no other interfaces involved.
 //
 //  * When discarding messages sent on an interface, which can be done by
 //    discarding the returned request.
 template <typename Interface>
-AssociatedInterfaceRequest<Interface> GetIsolatedProxy(
+AssociatedInterfaceRequest<Interface> MakeIsolatedRequest(
     AssociatedInterfacePtr<Interface>* ptr) {
   MessagePipe pipe;
   scoped_refptr<internal::MultiplexRouter> router0 =
       new internal::MultiplexRouter(std::move(pipe.handle0),
                                     internal::MultiplexRouter::MULTI_INTERFACE,
                                     false, base::ThreadTaskRunnerHandle::Get());
   scoped_refptr<internal::MultiplexRouter> router1 =
       new internal::MultiplexRouter(std::move(pipe.handle1),
                                     internal::MultiplexRouter::MULTI_INTERFACE,
                                     true, base::ThreadTaskRunnerHandle::Get());
 
   ScopedInterfaceEndpointHandle endpoint0, endpoint1;
   ScopedInterfaceEndpointHandle::CreatePairPendingAssociation(&endpoint0,
                                                               &endpoint1);
   InterfaceId id = router1->AssociateInterface(std::move(endpoint0));
   endpoint0 = router0->CreateLocalEndpointHandle(id);
 
   ptr->Bind(AssociatedInterfacePtrInfo<Interface>(std::move(endpoint0),
                                                   Interface::Version_));
 
   AssociatedInterfaceRequest<Interface> request;
   request.Bind(std::move(endpoint1));
   return request;
 }
 
-// Creates an associated interface proxy in its own AssociatedGroup.
-// TODO(yzshen): Rename GetIsolatedProxy() to MakeIsolatedRequest(), and change
-// all callsites of this function to directly use that.
-template <typename Interface>
-AssociatedInterfaceRequest<Interface> MakeRequestForTesting(
-    AssociatedInterfacePtr<Interface>* ptr) {
-  return GetIsolatedProxy(ptr);
-}
-
 }  // namespace mojo
 
 #endif  // MOJO_PUBLIC_CPP_BINDINGS_ASSOCIATED_INTERFACE_PTR_H_