Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2258)

Issue 2705493003: Revert of Don't pixel-snap overflow clips in clip paint property nodes. (Closed)

Created:
3 years, 10 months ago by Matt Giuca
Modified:
3 years, 10 months ago
Reviewers:
chrishtr, Xianzhu
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Don't pixel-snap overflow clips in clip paint property nodes. (patchset #5 id:80001 of https://codereview.chromium.org/2701523003/ ) Reason for revert: Failing layout test on Mac: paint/invalidation/select-option-background-color.html BUG=693345 Original issue's description: > Don't pixel-snap overflow clips in clip paint property nodes. > > Pixel-snapping should be applied at "paint" time instead, based on context > which includes subpixel accumulation. > > Also, adds code to apply subpixel accumulation for overflow clip rects applied > to background clip rects. > > BUG=691959 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Review-Url: https://codereview.chromium.org/2701523003 > Cr-Commit-Position: refs/heads/master@{#451189} > Committed: https://chromium.googlesource.com/chromium/src/+/19b6d116165378bc06ae204d74b5b1da58caa9ab TBR=wangxianzhu@chromium.org,chrishtr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=691959

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -44 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp View 5 chunks +11 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Matt Giuca
Created Revert of Don't pixel-snap overflow clips in clip paint property nodes.
3 years, 10 months ago (2017-02-17 04:00:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705493003/1
3 years, 10 months ago (2017-02-17 04:01:03 UTC) #3
Xianzhu
On 2017/02/17 04:01:03, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
3 years, 10 months ago (2017-02-17 04:02:31 UTC) #5
Matt Giuca
On 2017/02/17 04:02:31, Xianzhu wrote: > On 2017/02/17 04:01:03, commit-bot: I haz the power wrote: ...
3 years, 10 months ago (2017-02-17 04:03:49 UTC) #6
Xianzhu
3 years, 10 months ago (2017-02-17 04:16:13 UTC) #7
On 2017/02/17 04:03:49, Matt Giuca wrote:
> On 2017/02/17 04:02:31, Xianzhu wrote:
> > On 2017/02/17 04:01:03, commit-bot: I haz the power wrote:
> > > CQ is trying da patch. Follow status at
> > >  
> > >
> >
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
> > 
> > A while please. Let me check the reason of the failure. Perhaps we just need
a
> > rebaseline.
> 
> OK, but please address this within 30 minutes or so; otherwise I will revert
and
> then you can take your time and reland.

Thanks. Closing this revert in favor of
https://codereview.chromium.org/2694623015.

Powered by Google App Engine
This is Rietveld 408576698