Rebaseline paint/invalidation/select-option-background-color.html on Mac

Rebaseline paint/invalidation/select-option-background-color.html on Mac

BUG=691959
TBR=mgiuca@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2694623015
Cr-Commit-Position: refs/heads/master@{#451205}
Committed: https://chromium.googlesource.com/chromium/src/+/6bb957fdd7376485034caeeaad8bc3d3413aa23c

[Xianzhu, 2017-02-17 04:11:24]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2017-02-17 04:12:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 04:13:18]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487304684791690, "parent_rev":
"4f5cea4f7970a0e79f88c94959126187ef0be744", "commit_rev":
"6bb957fdd7376485034caeeaad8bc3d3413aa23c"}

[commit-bot: I haz the power, 2017-02-17 04:15:02]

Description was changed from

==========
Rebaseline paint/invalidation/select-option-background-color.html on Mac

BUG=691959
TBR=mgiuca@chromium.org
NOTRY=true
NOPRESUBMIT=true
==========

to

==========
Rebaseline paint/invalidation/select-option-background-color.html on Mac

BUG=691959
TBR=mgiuca@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2694623015
Cr-Commit-Position: refs/heads/master@{#451205}
Committed:
https://chromium.googlesource.com/chromium/src/+/6bb957fdd7376485034caeeaad8b...
==========

[commit-bot: I haz the power, 2017-02-17 04:15:03]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6bb957fdd7376485034caeeaad8b...

[Matt Giuca, 2017-02-17 04:21:47]

Thanks for responding to this quickly.

However, in future, PLEASE DO NOT USE notry / nopresubmit unless you need to
force something around the CQ because it is urgent or won't land otherwise
(i.e., you are sheriffing and things are really bad).

Just fixing a broken test is not urgent enough; we generally run this type of CL
through the full CQ just to make sure it doesn't break something else.

[Matt Giuca, 2017-02-17 04:22:14]

(Also lgtm)

[Matt Giuca, 2017-02-17 04:23:18]

On 2017/02/17 04:22:14, Matt Giuca wrote:
> (Also lgtm)

Also the right bug for this issue is crbug.com/693345.

[Xianzhu, 2017-02-17 04:26:41]

On 2017/02/17 04:21:47, Matt Giuca wrote:
> Thanks for responding to this quickly.
> 
> However, in future, PLEASE DO NOT USE notry / nopresubmit unless you need to
> force something around the CQ because it is urgent or won't land otherwise
> (i.e., you are sheriffing and things are really bad).
> 
> Just fixing a broken test is not urgent enough; we generally run this type of
CL
> through the full CQ just to make sure it doesn't break something else.

This is done with a script "webkit-patch rebaseline-cl", just like an manual
version of auto-rebaseline on the rebaseline bot which automatically lands
auto-rebaselines with NOTRY and NOPRESUBMIT.

The CQ was suffering from big backlog.

I'm looking at the bots.

The failure was because CQs don't have enough coverage on certain OS variants.
Sometimes we have to depend on the waterfall bots to discover the needs of
rebaselines. The rebaseline script fetches actual results from the bots and
update the expectations.

[Xianzhu, 2017-02-17 04:29:17]

On 2017/02/17 04:23:18, Matt Giuca wrote:
> On 2017/02/17 04:22:14, Matt Giuca wrote:
> > (Also lgtm)
> 
> Also the right bug for this issue is crbug.com/693345.

Oh I didn't notice you filed a bug for the failure. The bug number is for the
original change which required the rebaseline.

[Xianzhu, 2017-02-17 04:30:56]

On 2017/02/17 04:26:41, Xianzhu wrote:
> On 2017/02/17 04:21:47, Matt Giuca wrote:
> > Thanks for responding to this quickly.
> > 
> > However, in future, PLEASE DO NOT USE notry / nopresubmit unless you need to
> > force something around the CQ because it is urgent or won't land otherwise
> > (i.e., you are sheriffing and things are really bad).
> > 
> > Just fixing a broken test is not urgent enough; we generally run this type
of
> CL
> > through the full CQ just to make sure it doesn't break something else.
> 
> This is done with a script "webkit-patch rebaseline-cl", just like an manual
s/rebaseline-cl/rebaseline-expectation/

'rebaseline-cl' is very broken for now, otherwise we would have used that before
landing the original CL.

> version of auto-rebaseline on the rebaseline bot which automatically lands
> auto-rebaselines with NOTRY and NOPRESUBMIT.
> 
> The CQ was suffering from big backlog.
> 
> I'm looking at the bots.
> 
> The failure was because CQs don't have enough coverage on certain OS variants.
> Sometimes we have to depend on the waterfall bots to discover the needs of
> rebaselines. The rebaseline script fetches actual results from the bots and
> update the expectations.

[Matt Giuca, 2017-02-17 04:30:58]

On 2017/02/17 04:26:41, Xianzhu wrote:
> On 2017/02/17 04:21:47, Matt Giuca wrote:
> > Thanks for responding to this quickly.
> > 
> > However, in future, PLEASE DO NOT USE notry / nopresubmit unless you need to
> > force something around the CQ because it is urgent or won't land otherwise
> > (i.e., you are sheriffing and things are really bad).
> > 
> > Just fixing a broken test is not urgent enough; we generally run this type
of
> CL
> > through the full CQ just to make sure it doesn't break something else.
> 
> This is done with a script "webkit-patch rebaseline-cl", just like an manual
> version of auto-rebaseline on the rebaseline bot which automatically lands
> auto-rebaselines with NOTRY and NOPRESUBMIT.

Oh OK thanks for letting me know. That sounds really bad; let's fix this.

> 
> The CQ was suffering from big backlog.
> 
> I'm looking at the bots.
> 
> The failure was because CQs don't have enough coverage on certain OS variants.
> Sometimes we have to depend on the waterfall bots to discover the needs of
> rebaselines. The rebaseline script fetches actual results from the bots and
> update the expectations.