Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 2705433003: DevTools: decouple model logic from presentation within CSSTrackerView (Closed)

Created:
3 years, 10 months ago by caseq
Modified:
3 years, 10 months ago
Reviewers:
alph, dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: decouple model logic from presentation within CSSTrackerView This simplifies the rules usage and stylesheet processing logic in CSSTrackerView from the presentation code that lays a way for future splitting this view into several parts. This also groups rules by styleshetts early that simplifies processing in several places. Review-Url: https://codereview.chromium.org/2705433003 Cr-Commit-Position: refs/heads/master@{#451429} Committed: https://chromium.googlesource.com/chromium/src/+/d6fa448cd41d51f3b637f5bcfa4d6aac5d13abb8

Patch Set 1 #

Total comments: 12

Patch Set 2 : Review comments addressed #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -142 lines) Patch
M third_party/WebKit/LayoutTests/inspector/css_tracker/css-tracker-view.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/css_tracker/decorations-after-inplace-formatter.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/css_tracker/highlight-in-source.html View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/css_tracker/CSSTrackerView.js View 1 2 chunks +106 lines, -132 lines 1 comment Download

Messages

Total messages: 28 (14 generated)
caseq
3 years, 10 months ago (2017-02-17 03:08:45 UTC) #2
alph
lgtm % comments https://codereview.chromium.org/2705433003/diff/1/third_party/WebKit/Source/devtools/front_end/css_tracker/CSSTrackerView.js File third_party/WebKit/Source/devtools/front_end/css_tracker/CSSTrackerView.js (right): https://codereview.chromium.org/2705433003/diff/1/third_party/WebKit/Source/devtools/front_end/css_tracker/CSSTrackerView.js#newcode85 third_party/WebKit/Source/devtools/front_end/css_tracker/CSSTrackerView.js:85: cssModel.ruleListPromise() nit: wanna be a cool ...
3 years, 10 months ago (2017-02-17 19:08:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705433003/20001
3 years, 10 months ago (2017-02-17 21:57:11 UTC) #6
caseq
https://codereview.chromium.org/2705433003/diff/1/third_party/WebKit/Source/devtools/front_end/css_tracker/CSSTrackerView.js File third_party/WebKit/Source/devtools/front_end/css_tracker/CSSTrackerView.js (right): https://codereview.chromium.org/2705433003/diff/1/third_party/WebKit/Source/devtools/front_end/css_tracker/CSSTrackerView.js#newcode85 third_party/WebKit/Source/devtools/front_end/css_tracker/CSSTrackerView.js:85: cssModel.ruleListPromise() On 2017/02/17 19:08:55, alph wrote: > nit: wanna ...
3 years, 10 months ago (2017-02-17 22:22:18 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/121899)
3 years, 10 months ago (2017-02-17 23:53:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705433003/20001
3 years, 10 months ago (2017-02-17 23:55:43 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on ...
3 years, 10 months ago (2017-02-18 00:01:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705433003/20001
3 years, 10 months ago (2017-02-18 00:04:23 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 10 months ago (2017-02-18 01:58:38 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705433003/20001
3 years, 10 months ago (2017-02-18 02:00:10 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 10 months ago (2017-02-18 02:06:27 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705433003/20001
3 years, 10 months ago (2017-02-18 04:33:48 UTC) #23
dgozman
https://codereview.chromium.org/2705433003/diff/20001/third_party/WebKit/Source/devtools/front_end/css_tracker/CSSTrackerView.js File third_party/WebKit/Source/devtools/front_end/css_tracker/CSSTrackerView.js (right): https://codereview.chromium.org/2705433003/diff/20001/third_party/WebKit/Source/devtools/front_end/css_tracker/CSSTrackerView.js#newcode84 third_party/WebKit/Source/devtools/front_end/css_tracker/CSSTrackerView.js:84: var cssModel = mainTarget.model(SDK.CSSModel); While you are working on ...
3 years, 10 months ago (2017-02-18 06:21:09 UTC) #25
commit-bot: I haz the power
3 years, 10 months ago (2017-02-18 06:35:33 UTC) #28
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d6fa448cd41d51f3b637f5bcfa4d...

Powered by Google App Engine
This is Rietveld 408576698