third_party/WebKit/LayoutTests/inspector/css_tracker/decorations-after-inplace-formatter.html - Issue 2705433003: DevTools: decouple model logic from presentation within CSSTrackerView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/css_tracker/decorations-after-inplace-formatter.html

Issue 2705433003: DevTools: decouple model logic from presentation within CSSTrackerView (Closed)

Patch Set: Review comments addressed Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/css_tracker/css-tracker-view.html ('k') | third_party/WebKit/LayoutTests/inspector/css_tracker/highlight-in-source.html » ('j') | third_party/WebKit/Source/devtools/front_end/css_tracker/CSSTrackerView.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/css_tracker/decorations-after-inplace-formatter.html

diff --git a/third_party/WebKit/LayoutTests/inspector/css_tracker/decorations-after-inplace-formatter.html b/third_party/WebKit/LayoutTests/inspector/css_tracker/decorations-after-inplace-formatter.html

index f7b3fdbd7797fcfc97600a6073fdb16f941f4472..86adbdb79903e2e6ebf67c1a1b3789581b678b68 100644

--- a/third_party/WebKit/LayoutTests/inspector/css_tracker/decorations-after-inplace-formatter.html

+++ b/third_party/WebKit/LayoutTests/inspector/css_tracker/decorations-after-inplace-formatter.html

@@ -17,7 +17,7 @@ function test()

var scriptFormatter;

var tracker = self.runtime.sharedInstance(CSSTracker.CSSTrackerView);

- InspectorTest.addSniffer(CSSTracker.CSSTrackerView.prototype, "_renderRuleUsage", onTracingFinished);

+ InspectorTest.addSniffer(CSSTracker.CSSTrackerView.prototype, "_updateGutter", onTracingFinished);

tracker._toggleRecording(true);

UI.viewManager.showView("css_tracker");

@@ -55,7 +55,7 @@ function test()

InspectorTest.addResult(lines);

InspectorTest.completeTest();

}

function inplaceFormatter()

{

return self.runtime.allInstances(Sources.SourcesView.EditorAction).then(function(editorActions) {