Add checkdeps to tools/presubmit.py.

Add checkdeps to tools/presubmit.py.

Adding a full run of checkdeps to tools/presubmit.py so that we keep
checkdeps green. PRESUBMIT.py checks only incremental changes.

Temporarily disabling a check rule that's broker in the inspector,
pending owners fix.

BUG=
R=machenbach@chromium.org,dgozman@chromium.org,eholk@chromium.org

Review-Url: https://codereview.chromium.org/2705333005
Cr-Commit-Position: refs/heads/master@{#43397}
Committed: https://chromium.googlesource.com/v8/v8/+/40ab666bca945fe1bde78e1f20794988851121bf

[bradnelson, 2017-02-23 01:27:01]

The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 01:27:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bradn, 2017-02-23 01:27:18]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[bradn, 2017-02-23 01:27:35]

Description was changed from

==========
Add checkdeps to tools/presubmit.py.

Adding a full run of checkdeps to tools/presubmit.py so that we keep
checkdeps green. PRESUBMIT.py checks only incremental changes.

Temporarily disabling a check rule that's broker in the inspector,
pending owners fix.

BUG=
R=machenbach@chromium.org,dgozman@chromium.org
==========

to

==========
Add checkdeps to tools/presubmit.py.

Adding a full run of checkdeps to tools/presubmit.py so that we keep
checkdeps green. PRESUBMIT.py checks only incremental changes.

Temporarily disabling a check rule that's broker in the inspector,
pending owners fix.

BUG=
R=machenbach@chromium.org,dgozman@chromium.org,eholk@chromium.org
==========

[bradn, 2017-02-23 01:27:35]

bradnelson@google.com changed reviewers:
+ eholk@chromium.org

[commit-bot: I haz the power, 2017-02-23 01:47:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 01:47:28]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-02-23 01:49:48]

[+kozy FYI]

inspector lgtm, we will follow up.

[Eric Holk, 2017-02-23 02:30:36]

lgtm

[kozy, 2017-02-23 16:46:15]

kozyatinskiy@chromium.org changed reviewers:
+ kozyatinskiy@chromium.org

[kozy, 2017-02-23 16:46:15]

thanks!
I'll land fix [1] after this CL. 

[1] https://codereview.chromium.org/2710243002/

[bradn, 2017-02-23 23:13:44]

The CQ bit was checked by bradnelson@google.com

[commit-bot: I haz the power, 2017-02-23 23:13:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 23:15:50]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487891624098770, "parent_rev":
"990c59d8b9060179165f1bcc911ec0ac7ad2a2d8", "commit_rev":
"40ab666bca945fe1bde78e1f20794988851121bf"}

[commit-bot: I haz the power, 2017-02-23 23:15:55]

Description was changed from

==========
Add checkdeps to tools/presubmit.py.

Adding a full run of checkdeps to tools/presubmit.py so that we keep
checkdeps green. PRESUBMIT.py checks only incremental changes.

Temporarily disabling a check rule that's broker in the inspector,
pending owners fix.

BUG=
R=machenbach@chromium.org,dgozman@chromium.org,eholk@chromium.org
==========

to

==========
Add checkdeps to tools/presubmit.py.

Adding a full run of checkdeps to tools/presubmit.py so that we keep
checkdeps green. PRESUBMIT.py checks only incremental changes.

Temporarily disabling a check rule that's broker in the inspector,
pending owners fix.

BUG=
R=machenbach@chromium.org,dgozman@chromium.org,eholk@chromium.org

Review-Url: https://codereview.chromium.org/2705333005
Cr-Commit-Position: refs/heads/master@{#43397}
Committed:
https://chromium.googlesource.com/v8/v8/+/40ab666bca945fe1bde78e1f20794988851...
==========

[commit-bot: I haz the power, 2017-02-23 23:15:56]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/40ab666bca945fe1bde78e1f20794988851...

[Michael Achenbach, 2017-02-24 09:07:16]

Did you measure how long this runs? Maybe it should run on our CQ bot as it
already lead to the first failure on CI:
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20presubmit/bu...

[bradn, 2017-02-27 04:54:12]

< 1 second.

Can we afford the total 16 seconds for tools/presubmit.py on the CQ too?

[Michael Achenbach, 2017-02-27 07:44:49]

On 2017/02/27 04:54:12, bradn wrote:
> < 1 second.
> 
> Can we afford the total 16 seconds for tools/presubmit.py on the CQ too?

The other things from tools/presubmit.py are already running on CQ. They only
run on affected files from the patch and therefore run fast. See how they are
hooked up in PRESUBMIT.py. I think checkdeps should just run on everything no
matter what if it's so fast.