Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 2705303002: Revert of Use ScopedCrashKey for RendererDidNavigate crash dumps (Closed)

Created:
3 years, 10 months ago by jam
Modified:
3 years, 10 months ago
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use ScopedCrashKey for RendererDidNavigate crash dumps (patchset #4 id:60001 of https://codereview.chromium.org/2696193006/ ) Reason for revert: We got the data we wanted. Original issue's description: > Use ScopedCrashKey for RendererDidNavigate crash dumps > > This will make the crash reports easier to view. > > BUG=688425 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Review-Url: https://codereview.chromium.org/2696193006 > Cr-Commit-Position: refs/heads/master@{#451501} > Committed: https://chromium.googlesource.com/chromium/src/+/b1730dabdf125160dc23db993e08f453fc648fc8 TBR=creis@chromium.org,rsesek@chromium.org,ananta@chromium.org,estark@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=688425 Review-Url: https://codereview.chromium.org/2705303002 Cr-Commit-Position: refs/heads/master@{#451834} Committed: https://chromium.googlesource.com/chromium/src/+/7e735c119621aadf893858adb6c37b58325d5e94

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -29 lines) Patch
M chrome/app/chrome_crash_reporter_client_win.cc View 3 chunks +14 lines, -18 lines 0 comments Download
M chrome/common/crash_keys.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl.cc View 2 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
jam
Created Revert of Use ScopedCrashKey for RendererDidNavigate crash dumps
3 years, 10 months ago (2017-02-21 18:40:04 UTC) #2
estark
lgtm
3 years, 10 months ago (2017-02-21 18:40:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705303002/1
3 years, 10 months ago (2017-02-21 18:40:42 UTC) #4
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 21:19:34 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7e735c119621aadf893858adb6c3...

Powered by Google App Engine
This is Rietveld 408576698