Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2705293005: Convert LayoutTests/svg/dom/SVGAnimated*.html js-tests.js to testharness.js based tests. (Closed)

Created:
3 years, 10 months ago by Shanmuga Pandi
Modified:
3 years, 10 months ago
Reviewers:
Srirama, fs
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert LayoutTests/svg/dom/SVGAnimated*.html js-tests.js to testharness.js based tests. BUG=636710 Review-Url: https://codereview.chromium.org/2705293005 Cr-Commit-Position: refs/heads/master@{#452034} Committed: https://chromium.googlesource.com/chromium/src/+/a20638f48bc2cc3dc2dea9747fdad449b399622f

Patch Set 1 #

Total comments: 2

Patch Set 2 : Align with review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -369 lines) Patch
M third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedAngle.html View 1 chunk +33 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedAngle-expected.txt View 1 chunk +0 lines, -27 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedBoolean.html View 1 1 chunk +45 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedBoolean-expected.txt View 1 chunk +0 lines, -35 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedInteger.html View 1 chunk +35 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedInteger-expected.txt View 1 chunk +0 lines, -30 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedPreserveAspectRatio.html View 1 chunk +41 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedPreserveAspectRatio-expected.txt View 1 chunk +0 lines, -31 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedRect.html View 1 chunk +33 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedRect-expected.txt View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/script-tests/SVGAnimatedAngle.js View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/script-tests/SVGAnimatedBoolean.js View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/script-tests/SVGAnimatedInteger.js View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/script-tests/SVGAnimatedPreserveAspectRatio.js View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/script-tests/SVGAnimatedRect.js View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Shanmuga Pandi
On 2017/02/22 12:02:25, Shanmuga Pandi wrote: > mailto:shanmuga.m@samsung.com changed reviewers: > + mailto:fs@opera.com, mailto:srirama.m@samsung.com PTAL!!
3 years, 10 months ago (2017-02-22 12:02:36 UTC) #3
fs
lgtm https://codereview.chromium.org/2705293005/diff/1/third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedBoolean.html File third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedBoolean.html (right): https://codereview.chromium.org/2705293005/diff/1/third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedBoolean.html#newcode31 third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedBoolean.html:31: assert_equals(convElement.preserveAlpha.baseVal, convElement.preserveAlpha.baseVal); Drop this.
3 years, 10 months ago (2017-02-22 13:11:00 UTC) #4
Shanmuga Pandi
https://codereview.chromium.org/2705293005/diff/1/third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedBoolean.html File third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedBoolean.html (right): https://codereview.chromium.org/2705293005/diff/1/third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedBoolean.html#newcode31 third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedBoolean.html:31: assert_equals(convElement.preserveAlpha.baseVal, convElement.preserveAlpha.baseVal); On 2017/02/22 13:10:59, fs wrote: > Drop ...
3 years, 10 months ago (2017-02-22 13:14:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705293005/20001
3 years, 10 months ago (2017-02-22 13:14:45 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 14:14:17 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a20638f48bc2cc3dc2dea9747fda...

Powered by Google App Engine
This is Rietveld 408576698