Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 2705293003: Remove DumpWithoutCrashing() and keys from audio_manager (Closed)

Created:
3 years, 10 months ago by scottmg
Modified:
3 years, 10 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove DumpWithoutCrashing() and keys from audio_manager Reports are no longer being gathered and there's nothing further we can learn at this point. Part of trying to rationalize all calls to DumpWithoutCrashing(). R=dalecurtis@chromium.org BUG=422522, 694688 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2705293003 Cr-Commit-Position: refs/heads/master@{#452188} Committed: https://chromium.googlesource.com/chromium/src/+/cb4e0caa63778779d1fadfe2b31e418e6502f8c0

Patch Set 1 #

Patch Set 2 : remove unnecessary #includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -50 lines) Patch
M chrome/app/chrome_crash_reporter_client_win.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/common/crash_keys.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M media/audio/audio_manager.h View 2 chunks +1 line, -10 lines 0 comments Download
M media/audio/audio_manager.cc View 1 6 chunks +0 lines, -33 lines 0 comments Download

Messages

Total messages: 24 (16 generated)
scottmg
3 years, 10 months ago (2017-02-21 20:44:05 UTC) #6
DaleCurtis
lgtm, thanks!
3 years, 10 months ago (2017-02-21 21:25:42 UTC) #7
scottmg
+rsesek for chrome/common/crash_keys.cc OWNERS (I should probably add myself for that one.)
3 years, 10 months ago (2017-02-21 21:32:09 UTC) #10
Robert Sesek
lgtm
3 years, 10 months ago (2017-02-21 21:49:15 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705293003/20001
3 years, 10 months ago (2017-02-21 21:50:56 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on ...
3 years, 10 months ago (2017-02-21 23:38:59 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705293003/20001
3 years, 10 months ago (2017-02-22 18:53:47 UTC) #21
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 20:44:08 UTC) #24
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cb4e0caa63778779d1fadfe2b31e...

Powered by Google App Engine
This is Rietveld 408576698