Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: media/audio/audio_manager.h

Issue 2705293003: Remove DumpWithoutCrashing() and keys from audio_manager (Closed)
Patch Set: remove unnecessary #includes Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/crash_keys.cc ('k') | media/audio/audio_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/audio_manager.h
diff --git a/media/audio/audio_manager.h b/media/audio/audio_manager.h
index 2826bcd7dba5e2b13cb350415f1280abd5fdcc62..613df4d2ee6c70ccfad1241c23b6a0d0bf7a752d 100644
--- a/media/audio/audio_manager.h
+++ b/media/audio/audio_manager.h
@@ -39,9 +39,7 @@ using ScopedAudioManagerPtr =
// the need to provide iterators over the existing streams.
//
// Except on OSX, a hang monitor for the audio thread is always created. When a
-// thread hang is detected, it is reported to UMA. Optionally, if called prior,
-// EnableCrashKeyLoggingForAudioThreadHangs() will cause a non-crash dump to be
-// logged on Windows (this allows us to report driver hangs to Microsoft).
+// thread hang is detected, it is reported to UMA.
class MEDIA_EXPORT AudioManager {
public:
// Construct the audio manager; only one instance is allowed.
@@ -77,13 +75,6 @@ class MEDIA_EXPORT AudioManager {
static void StartHangMonitorIfNeeded(
scoped_refptr<base::SingleThreadTaskRunner> task_runner);
- // Enables non-crash dumps when audio thread hangs are detected.
- // TODO(dalecurtis): There are no callers to this function at present. A list
- // of bad drivers has been given to Microsoft. This should be re-enabled in
- // the future if Microsoft is able to triage third party drivers.
- // See http://crbug.com/422522
- static void EnableCrashKeyLoggingForAudioThreadHangs();
-
#if defined(OS_LINUX)
// Sets the name of the audio source as seen by external apps. Only actually
// used with PulseAudio as of this writing.
« no previous file with comments | « chrome/common/crash_keys.cc ('k') | media/audio/audio_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698