Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2705263003: Revert of Avoid pathological layout on nested percent height tables (patchset #5 id:80001 of https:… (Closed)

Created:
3 years, 10 months ago by gkihumba
Modified:
3 years, 10 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Revert of Avoid pathological layout on nested percent height tables (patchset #5 id:80001 of https://codereview.chromium.org/2670603002/ ) Reason for revert: Broke Google Hangouts. BUG=693722 Original issue's description: > Avoid unnecessary cell layout on nested percent height tables > > In the test, the nested percent height tables mean that each cell will get at > least three layouts (LayoutTableRow::layout(),calcRowLogicalHeight(), layoutRows()) > during the layout of the section - and this cascades down the tree with the lowest > children getting hundreds of repeated layouts. > > This inefficiency has always been there, we've just introduced it for the > percent height situation with crrev.com/2441373002. > > To avoid this don't bother computing the height of the section based on row sizes (calcRowLogicalHeight()), > unless the section itself needed a layout - the previously calculated value will do. > > The only complication this introduces is: any extra logical height from the > table that we previously discarded when distributing to the rows we will now > try to distribute again. This can change the size of the section and cause extra > paints. > > > BUG=687061 > > Review-Url: https://codereview.chromium.org/2670603002 > Cr-Commit-Position: refs/heads/master@{#449101} > Committed: https://chromium.googlesource.com/chromium/src/+/d3ceb0147ad9f4d4a9b41cea0362d6221cb72302 TBR=mstensho@opera.com,robhogan@gmail.com BUG=687061 NOTRY=true Review-Url: https://codereview.chromium.org/2700183003 Cr-Commit-Position: refs/heads/master@{#451451} (cherry picked from commit 91d8afa35df85de452b08ca5c7032fb1456a541a) Review-Url: https://codereview.chromium.org/2705263003 . Cr-Commit-Position: refs/branch-heads/2924@{#927} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/d22377e14ce7c0fd6324b7771cee0fd3fa200ed1

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
gkihumba
3 years, 10 months ago (2017-02-21 20:43:09 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d22377e14ce7c0fd6324b7771cee0fd3fa200ed1.

Powered by Google App Engine
This is Rietveld 408576698