Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2705213003: Refined types for most HtmlElement factory constructors (Closed)

Created:
3 years, 10 months ago by sra1
Modified:
3 years, 10 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Refined types for most HtmlElement factory constructors The body of new DivElement() is marked as returning a DivElement, instead of inferred to return Element. The more precise receiver type allows svg polyfills to be excluded, allowsing the HtmlElement methods to be identified as the single target and inlined. This tends to improve the code generated for idioms like new DivElement()..classes.add('foo') var e1 = new DivElement(); e1.children.add(e2); BUG= R=alanknight@google.com Committed: https://github.com/dart-lang/sdk/commit/b7b12b564a3e1811ccfca3e28fe30dde685f6633

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -176 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 49 chunks +91 lines, -86 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 4 chunks +41 lines, -36 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/scripts/css_code_generator.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/scripts/htmldartgenerator.py View 1 chunk +9 lines, -11 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 2 chunks +33 lines, -0 lines 0 comments Download
M tools/dom/scripts/systemnative.py View 1 chunk +7 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_DocumentFragment.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 2 chunks +39 lines, -34 lines 0 comments Download
M tools/dom/templates/html/impl/impl_SVGElement.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
sra1
3 years, 10 months ago (2017-02-22 04:56:47 UTC) #5
sra1
3 years, 10 months ago (2017-02-23 03:04:42 UTC) #6
Alan Knight
lgtm
3 years, 10 months ago (2017-02-23 17:46:10 UTC) #7
sra1
3 years, 10 months ago (2017-02-24 19:23:22 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:40001) manually as
b7b12b564a3e1811ccfca3e28fe30dde685f6633 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698