Refined types for most HtmlElement factory constructors

tools/dom/scripts/htmldartgenerator.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module provides shared functionality for the system to generate
 dart:html APIs from the IDL database."""
 
 import emitter
 from generator import AnalyzeOperation, ConstantOutputOrder, \
@@ skipping 554 matching lines @@
           type_name, constructor_info.declared_name)
       if conversion:
         return conversion.input_type
       else:
         return self._NarrowInputType(type_name) if type_name else 'dynamic'
 
     if constructor_info.pure_dart_constructor:
       # TODO(antonm): use common dispatcher generation for this case as well.
       has_optional = any(param_info.is_optional
           for param_info in constructor_info.param_infos)
-
+      factory_call = self.MakeFactoryCall(
+          factory_name, factory_constructor_name, factory_parameters,
+          constructor_info)
       if not has_optional:
         self._members_emitter.Emit(
             '\n  $(METADATA)'
             'factory $CTOR($PARAMS) => '
-            '$FACTORY.$CTOR_FACTORY_NAME($FACTORY_PARAMS);\n',
+            '$FACTORY_CALL;\n',
             CTOR=constructor_info._ConstructorFullName(self._DartType),
             PARAMS=constructor_info.ParametersAsDeclaration(InputType),
-            FACTORY=factory_name,
-            METADATA=metadata,
-            CTOR_FACTORY_NAME=factory_constructor_name,
-            FACTORY_PARAMS=factory_parameters)
+            FACTORY_CALL=factory_call,
+            METADATA=metadata)
       else:
         inits = self._members_emitter.Emit(
             '\n  $(METADATA)'
             'factory $CONSTRUCTOR($PARAMS) {\n'
-            '    $CONSTRUCTOR e = $FACTORY.$CTOR_FACTORY_NAME($FACTORY_PARAMS);\n'
+            '    $CONSTRUCTOR e = $FACTORY_CALL;\n'
             '$!INITS'
             '    return e;\n'
             '  }\n',
             CONSTRUCTOR=constructor_info._ConstructorFullName(self._DartType),
             METADATA=metadata,
-            FACTORY=factory_name,
-            CTOR_FACTORY_NAME=factory_constructor_name,
-            PARAMS=constructor_info.ParametersAsDeclaration(InputType),
-            FACTORY_PARAMS=factory_parameters)
+            FACTORY_CALL=factory_call,
+            PARAMS=constructor_info.ParametersAsDeclaration(InputType))
 
         for index, param_info in enumerate(constructor_info.param_infos):
           if param_info.is_optional:
             inits.Emit('    if ($E != null) e.$E = $E;\n', E=param_info.name)
     else:
       custom_factory_ctr = self._interface.id in _custom_factories
       constructor_full_name = constructor_info._ConstructorFullName(
           self._DartType)
 
       def GenerateCall(
@@ skipping 283 matching lines @@
   def _InputType(self, type_name, info):
     conversion = self._InputConversion(type_name, info.declared_name)
     if conversion:
       return conversion.input_type
     else:
       # If typedef it's a union return dynamic.
       if self._database.HasTypeDef(type_name):
         return 'dynamic'
       else:
         return self._NarrowInputType(type_name) if type_name else 'dynamic'