Refined types for most HtmlElement factory constructors

tools/dom/scripts/systemhtml.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module provides shared functionality for the system to generate
 Dart:html APIs from the IDL database."""
 
 import emitter
 import logging
@@ skipping 445 matching lines @@
     'WebGLRenderingContext': "JS('bool', '!!(window.WebGLRenderingContext)')",
     'WebSocket': "JS('bool', 'typeof window.WebSocket != \"undefined\"')",
     'Worker': "JS('bool', '(typeof window.Worker != \"undefined\")')",
     'XSLTProcessor': "JS('bool', '!!(window.XSLTProcessor)')",
   }.items() +
   dict((key,
         SvgSupportStr(_svg_element_constructors[key]) if key.startswith('SVG')
             else ElemSupportStr(_html_element_constructors[key])) for key in
     _js_support_checks_basic_element_with_constructors +
     _js_support_checks_additional_element).items())
+
+
+# JavaScript element class names of elements for which createElement does not
+# always return exactly the right element, either because it might not be
+# supported, or some browser does something weird.
+_js_unreliable_element_factories = set(
+    _js_support_checks_basic_element_with_constructors +
+    _js_support_checks_additional_element +
+    [
+        'HTMLEmbedElement',
+        'HTMLObjectElement',
+    ])
+
 # ------------------------------------------------------------------------------
 
 class HtmlDartInterfaceGenerator(object):
   """Generates dart interface and implementation for the DOM IDL interface."""
 
   def __init__(self, options, library_emitter, event_generator, interface,
                backend):
     self._renamer = options.renamer
     self._database = options.database
     self._template_loader = options.templates
@@ skipping 321 matching lines @@
       return (js_support_checks.get(self._interface.doc_js_name) +
           " && (new %sElement.tag('%s') is %s)" % (lib_prefix,
         constructors[self._interface.doc_js_name],
         self._renamer.RenameInterface(self._interface)))
     return js_support_checks.get(self._interface.doc_js_name)
 
   def GenerateCustomFactory(self, constructor_info):
     # Custom factory will be taken from the template.
     return self._interface.doc_js_name in _js_custom_constructors
 
+  def MakeFactoryCall(self, factory, method, arguments, constructor_info):
+    if factory is 'document' and method is 'createElement' \
+        and not ',' in arguments \
+        and not self._HasUnreliableFactoryConstructor():
+      return emitter.Format(
+          "JS('returns:$INTERFACE_NAME;creates:$INTERFACE_NAME;new:true',"
+          " '#.$METHOD(#)', $FACTORY, $ARGUMENTS)",
+          INTERFACE_NAME=self._interface_type_info.interface_name(),
+          FACTORY=factory,
+          METHOD=method,
+          ARGUMENTS=arguments)
+    return emitter.Format(
+        '$FACTORY.$METHOD($ARGUMENTS)',
+        FACTORY=factory,
+        METHOD=method,
+        ARGUMENTS=arguments)
+
+  def _HasUnreliableFactoryConstructor(self):
+    return self._interface.doc_js_name in _js_unreliable_element_factories
+
   def IsConstructorArgumentOptional(self, argument):
     return argument.optional
 
   def EmitStaticFactoryOverload(self, constructor_info, name, arguments):
     index = len(arguments)
     arguments = constructor_info.ParametersAsArgumentList(index)
     if arguments:
       arguments = ', ' + arguments
     self._members_emitter.Emit(
         "  static $INTERFACE_NAME $NAME($PARAMETERS) => "
@@ skipping 527 matching lines @@
 
   def AddFile(self, basename, library_name, path):
     self._libraries[library_name].AddFile(path)
 
   def AddTypeEntry(self, library_name, idl_name, dart_name):
     self._libraries[library_name].AddTypeEntry(idl_name, dart_name)
 
   def Emit(self, emitter, auxiliary_dir):
     for lib in self._libraries.values():
       lib.Emit(emitter, auxiliary_dir)