Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2705203003: color: Tests for fix accidental partial color conversion (Closed)

Created:
3 years, 10 months ago by ccameron
Modified:
3 years, 10 months ago
Reviewers:
msarett1, hubbe
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

color: Tests for fix accidental partial color conversion Add tests for this issue. BUG=694191 Review-Url: https://codereview.chromium.org/2705203003 Cr-Commit-Position: refs/heads/master@{#452236} Committed: https://chromium.googlesource.com/chromium/src/+/86a6cab9976c0355b241d85c30655c2ae51d0005

Patch Set 1 #

Patch Set 2 : Add tests #

Patch Set 3 : Just the tests #

Patch Set 4 : Try w/o hooks #

Patch Set 5 : Use smaller ICC profile #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -1 line) Patch
M ui/gfx/color_transform_unittest.cc View 1 2 3 4 1 chunk +45 lines, -0 lines 0 comments Download
M ui/gfx/icc_profile.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gfx/icc_profile.cc View 1 2 3 4 2 chunks +2 lines, -1 line 2 comments Download
M ui/gfx/test/icc_profiles.h View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gfx/test/icc_profiles.cc View 1 2 3 4 2 chunks +176 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
ccameron
ptal The test file that is added (it only sometimes shows up in cr) is ...
3 years, 10 months ago (2017-02-21 21:54:44 UTC) #5
ccameron
On 2017/02/21 21:54:44, ccameron wrote: > ptal > > The test file that is added ...
3 years, 10 months ago (2017-02-21 22:07:01 UTC) #7
ccameron
ptal Thanks for the smaller ICC profile -- that works!
3 years, 10 months ago (2017-02-22 20:56:06 UTC) #9
msarett1
lgtm https://codereview.chromium.org/2705203003/diff/50001/ui/gfx/icc_profile.cc File ui/gfx/icc_profile.cc (right): https://codereview.chromium.org/2705203003/diff/50001/ui/gfx/icc_profile.cc#newcode37 ui/gfx/icc_profile.cc:37: uint64_t next_unused_id = 10; I don't really understand ...
3 years, 10 months ago (2017-02-22 20:58:46 UTC) #10
ccameron
Thanks! https://codereview.chromium.org/2705203003/diff/50001/ui/gfx/icc_profile.cc File ui/gfx/icc_profile.cc (right): https://codereview.chromium.org/2705203003/diff/50001/ui/gfx/icc_profile.cc#newcode37 ui/gfx/icc_profile.cc:37: uint64_t next_unused_id = 10; On 2017/02/22 20:58:46, msarett1 ...
3 years, 10 months ago (2017-02-22 21:03:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705203003/50001
3 years, 10 months ago (2017-02-22 21:04:35 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 22:28:52 UTC) #16
Message was sent while issue was closed.
Committed patchset #5 (id:50001) as
https://chromium.googlesource.com/chromium/src/+/86a6cab9976c0355b241d85c3065...

Powered by Google App Engine
This is Rietveld 408576698