color: Tests for fix accidental partial color conversion

ui/gfx/icc_profile.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/icc_profile.h"
 
 #include <list>
 
 #include "base/containers/mru_cache.h"
 #include "base/lazy_instance.h"
 #include "base/synchronization/lock.h"
 #include "third_party/skia/include/core/SkICC.h"
 #include "ui/gfx/color_transform.h"
 
 namespace gfx {
 
 const uint64_t ICCProfile::test_id_adobe_rgb_ = 1;
 const uint64_t ICCProfile::test_id_color_spin_ = 2;
 const uint64_t ICCProfile::test_id_generic_rgb_ = 3;
 const uint64_t ICCProfile::test_id_srgb_ = 4;
+const uint64_t ICCProfile::test_id_no_analytic_tr_fn_ = 5;
 
 namespace {
 const size_t kMinProfileLength = 128;
 const size_t kMaxProfileLength = 4 * 1024 * 1024;
 
 // Allow keeping around a maximum of 8 cached ICC profiles. Beware that
 // we will do a linear search thorugh currently-cached ICC profiles,
 // when creating a new ICC profile.
 const size_t kMaxCachedICCProfiles = 8;
 
 struct Cache {
   Cache() : id_to_icc_profile_mru(kMaxCachedICCProfiles) {}
   ~Cache() {}
 
   // Start from-ICC-data IDs at the end of the hard-coded test id list above.
-  uint64_t next_unused_id = 5;
+  uint64_t next_unused_id = 10;

[msarett1, 2017/02/22 20:58:46]

I don't really understand what's going on here.

[ccameron, 2017/02/22 21:03:27]

This is sort of weird. It's ensuring that we don't use any IDs less than 10,
because they'll conflict with the hard-coded IDs.

It's to paper over the fact that, in Chrome, the IDs are always created in the
browser process, and so are always unique, but during layout tests, some of the
IDs are created in the renderer process (for testing), and we need to make sure
that they don't conflict with the IDs coming from the browser process.

   base::MRUCache<uint64_t, ICCProfile> id_to_icc_profile_mru;
   base::Lock lock;
 };
 static base::LazyInstance<Cache> g_cache;
 
 }  // namespace
 
 ICCProfile::ICCProfile() = default;
 ICCProfile::ICCProfile(ICCProfile&& other) = default;
 ICCProfile::ICCProfile(const ICCProfile& other) = default;
@@ skipping 161 matching lines @@
     cache.id_to_icc_profile_mru.Put(id_, *this);
   }
 }
 
 // static
 bool ICCProfile::IsValidProfileLength(size_t length) {
   return length >= kMinProfileLength && length <= kMaxProfileLength;
 }
 
 }  // namespace gfx