Investigated cause of failing tests for non-standard-scheme matching

Investigated cause of failing tests for non-standard-scheme matching

Turns out it's caused by incorrect url parsing. The host is returned as ""
in this particular scenario. Raised bug for this.

BUG=692449, 694959
Review-Url: https://codereview.chromium.org/2705193003
Cr-Commit-Position: refs/heads/master@{#452787}
Committed: https://chromium.googlesource.com/chromium/src/+/9ad590d1e5dd205d13f39a6bff4795732d3be55a

[andypaicu, 2017-02-22 10:02:45]

Description was changed from

==========
Investigated cause of failing tests for non-standard-scheme matching

BUG=692449
==========

to

==========
Investigated cause of failing tests for non-standard-scheme matching

Turns out it's caused by incorrect url parsing. The host is returned as ""
in this particular scenario. Raised bug for this.

BUG=692449,694959
==========

[andypaicu, 2017-02-22 10:03:11]

andypaicu@chromium.org changed reviewers:
+ mkwst@chromium.org

[andypaicu, 2017-02-22 10:03:11]

https://codereview.chromium.org/2705193003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/csp/CSPSourceTest.cpp (right):

https://codereview.chromium.org/2705193003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/csp/CSPSourceTest.cpp:197:
EXPECT_FALSE(source.matches(KURL(base, "non-standard-scheme://a.com")));
Raised bug about this 694959

[andypaicu, 2017-02-22 10:03:18]

The CQ bit was checked by andypaicu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 10:04:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 11:03:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 11:03:43]

Dry run: This issue passed the CQ dry run.

[Mike West, 2017-02-22 15:38:44]

https://codereview.chromium.org/2705193003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/csp/CSPSourceTest.cpp (right):

https://codereview.chromium.org/2705193003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/csp/CSPSourceTest.cpp:197:
EXPECT_FALSE(source.matches(KURL(base, "non-standard-scheme://a.com")));
On 2017/02/22 at 10:03:11, andypaicu wrote:
> Raised bug about this 694959

I'd suggest that you actually add the scheme as standard in the test to verify
the same-scheme behavior for pages and blank schemes in the source expression.
That's what I hoped I was suggesting this morning. :)

[Mike West, 2017-02-24 09:05:16]

LGTM based on DEPS discussion. :) Land it once the tree's not red anymore.

[Mike West, 2017-02-24 09:07:08]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2017-02-24 09:07:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 10:25:44]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487927228919150, "parent_rev":
"e262421e78d33170893fd1985df28658ba45a811", "commit_rev":
"9ad590d1e5dd205d13f39a6bff4795732d3be55a"}

[commit-bot: I haz the power, 2017-02-24 10:26:41]

Description was changed from

==========
Investigated cause of failing tests for non-standard-scheme matching

Turns out it's caused by incorrect url parsing. The host is returned as ""
in this particular scenario. Raised bug for this.

BUG=692449,694959
==========

to

==========
Investigated cause of failing tests for non-standard-scheme matching

Turns out it's caused by incorrect url parsing. The host is returned as ""
in this particular scenario. Raised bug for this.

BUG=692449,694959

Review-Url: https://codereview.chromium.org/2705193003
Cr-Commit-Position: refs/heads/master@{#452787}
Committed:
https://chromium.googlesource.com/chromium/src/+/9ad590d1e5dd205d13f39a6bff47...
==========

[commit-bot: I haz the power, 2017-02-24 10:26:42]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9ad590d1e5dd205d13f39a6bff47...