Investigated cause of failing tests for non-standard-scheme matching

third_party/WebKit/Source/core/frame/csp/CSPSourceTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/frame/csp/CSPSource.h"
 
 #include "core/dom/Document.h"
 #include "core/frame/csp/ContentSecurityPolicy.h"
 #include "platform/network/ResourceRequest.h"
 #include "platform/weborigin/KURL.h"
@@ skipping 169 matching lines @@
     EXPECT_TRUE(source.matches(KURL(base, "ftp://a.com")));
   }
 
   // Self scheme is unique
   {
     Persistent<ContentSecurityPolicy> csp(ContentSecurityPolicy::create());
     csp->setupSelf(
         *SecurityOrigin::createFromString("non-standard-scheme://a.com/"));
     CSPSource source(csp.get(), "", "a.com", 0, "/", CSPSource::NoWildcard,
                      CSPSource::NoWildcard);
-    // TODO(mkwst, arthursonzogni): This result might be wrong.
-    // See http://crbug.com/692449
     EXPECT_FALSE(source.matches(KURL(base, "http://a.com")));
-    // TODO(mkwst, arthursonzogni): This result might be wrong.
-    // See http://crbug.com/692449
+
+    // The reason matching fails is because the host is parsed as "" when
+    // using a non standard scheme even though it should be parsed as "a.com"
+    // After adding it to the list of standard schemes it now gets parsed
+    // correctly. This does not matter in practice though because there is
+    // no way to render/load anything like "non-standard-scheme://a.com"
     EXPECT_FALSE(source.matches(KURL(base, "non-standard-scheme://a.com")));

[andypaicu, 2017/02/22 10:03:11]

Raised bug about this 694959

[Mike West, 2017/02/22 15:38:44]

I'd suggest that you actually add the scheme as standard in the test to verify
the same-scheme behavior for pages and blank schemes in the source expression.
That's what I hoped I was suggesting this morning. :)

   }
 }
 
 TEST_F(CSPSourceTest, InsecureHostSchemePortMatchesSecurePort) {
   KURL base;
 
   // source scheme is "http"
   {
     CSPSource source(csp.get(), "http", "example.com", 80, "/",
                      CSPSource::NoWildcard, CSPSource::NoWildcard);
@@ skipping 692 matching lines @@
     normalized = B->intersect(A);
     Source intersectBA = {
         normalized->m_scheme,       normalized->m_host,
         normalized->m_path,         normalized->m_port,
         normalized->m_hostWildcard, normalized->m_portWildcard};
     EXPECT_TRUE(equalSources(intersectBA, test.normalized));
   }
 }
 
 }  // namespace blink