Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2705163005: [csa] Add Unreachable() and use it after throw sites (Closed)

Created:
3 years, 10 months ago by jgruber
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[csa] Add Unreachable() and use it after throw sites This should improve readability, code generation, and ensure that we verify such locations are never reached. BUG= Review-Url: https://codereview.chromium.org/2705163005 Cr-Commit-Position: refs/heads/master@{#43367} Committed: https://chromium.googlesource.com/v8/v8/+/c7add4ce57d6424569a146aef9d04682cb40fc1c

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -69 lines) Patch
M src/builtins/builtins-array.cc View 1 2 chunks +8 lines, -10 lines 0 comments Download
M src/builtins/builtins-date.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M src/builtins/builtins-generator.cc View 1 2 chunks +7 lines, -8 lines 0 comments Download
M src/builtins/builtins-promise.cc View 7 chunks +8 lines, -9 lines 0 comments Download
M src/builtins/builtins-regexp.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/builtins/builtins-sharedarraybuffer.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M src/builtins/builtins-string.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M src/builtins/builtins-typedarray.cc View 1 1 chunk +5 lines, -6 lines 0 comments Download
M src/code-stub-assembler.cc View 1 5 chunks +10 lines, -15 lines 0 comments Download
M src/compiler/code-assembler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/code-assembler.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/machine-graph-verifier.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/raw-machine-assembler.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
jgruber
Hi guys, this adds Unreachable to CodeAssembler/RawMachineAssembler and then uses it after throwing runtime calls. ...
3 years, 10 months ago (2017-02-22 11:29:54 UTC) #10
Michael Starzinger
LGTM. Thanks!
3 years, 10 months ago (2017-02-22 11:56:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705163005/20001
3 years, 10 months ago (2017-02-22 12:00:51 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 12:02:41 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/c7add4ce57d6424569a146aef9d04682cb4...

Powered by Google App Engine
This is Rietveld 408576698