Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Side by Side Diff: src/compiler/machine-graph-verifier.cc

Issue 2705163005: [csa] Add Unreachable() and use it after throw sites (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/code-assembler.cc ('k') | src/compiler/raw-machine-assembler.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/machine-graph-verifier.h" 5 #include "src/compiler/machine-graph-verifier.h"
6 6
7 #include "src/compiler/common-operator.h" 7 #include "src/compiler/common-operator.h"
8 #include "src/compiler/graph.h" 8 #include "src/compiler/graph.h"
9 #include "src/compiler/linkage.h" 9 #include "src/compiler/linkage.h"
10 #include "src/compiler/machine-operator.h" 10 #include "src/compiler/machine-operator.h"
(...skipping 502 matching lines...) Expand 10 before | Expand all | Expand 10 after
513 CheckValueInputForInt32Op(node, input_index); 513 CheckValueInputForInt32Op(node, input_index);
514 break; 514 break;
515 default: 515 default:
516 CheckValueInputRepresentationIs( 516 CheckValueInputRepresentationIs(
517 node, 2, inferrer_->GetRepresentation(node)); 517 node, 2, inferrer_->GetRepresentation(node));
518 } 518 }
519 break; 519 break;
520 } 520 }
521 break; 521 break;
522 } 522 }
523 case IrOpcode::kThrow:
524 CheckValueInputIsTagged(node, 0);
525 break;
523 case IrOpcode::kTypedStateValues: 526 case IrOpcode::kTypedStateValues:
524 case IrOpcode::kFrameState: 527 case IrOpcode::kFrameState:
525 break; 528 break;
526 default: 529 default:
527 if (node->op()->ValueInputCount() != 0) { 530 if (node->op()->ValueInputCount() != 0) {
528 std::stringstream str; 531 std::stringstream str;
529 str << "Node #" << node->id() << ":" << *node->op() 532 str << "Node #" << node->id() << ":" << *node->op()
530 << " in the machine graph is not being checked."; 533 << " in the machine graph is not being checked.";
531 PrintDebugHelp(str, node); 534 PrintDebugHelp(str, node);
532 FATAL(str.str().c_str()); 535 FATAL(str.str().c_str());
(...skipping 275 matching lines...) Expand 10 before | Expand all | Expand 10 after
808 MachineRepresentationInferrer representation_inferrer(schedule, graph, 811 MachineRepresentationInferrer representation_inferrer(schedule, graph,
809 linkage, temp_zone); 812 linkage, temp_zone);
810 MachineRepresentationChecker checker(schedule, &representation_inferrer, 813 MachineRepresentationChecker checker(schedule, &representation_inferrer,
811 is_stub, name); 814 is_stub, name);
812 checker.Run(); 815 checker.Run();
813 } 816 }
814 817
815 } // namespace compiler 818 } // namespace compiler
816 } // namespace internal 819 } // namespace internal
817 } // namespace v8 820 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/code-assembler.cc ('k') | src/compiler/raw-machine-assembler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698