Do not use TabModel inside BlockedPopupInfo handler block.

Do not use TabModel inside BlockedPopupInfo handler block.

BlockedPopupInfo handler block will be folded into BlockedPopupHandler
which does not have access to TabModel.

Calling updateSnapshotWithOverlay:visibleFrameOnly: is unnecessary,
because it is called from TabInfoBarObserver::OnInfoBarRemoved.

Opening popup functionality was moved to
WebStateDelegate::OpenURLFromWebState, which is currently BVC.

BUG=692117
Review-Url: https://codereview.chromium.org/2705113004
Cr-Commit-Position: refs/heads/master@{#452278}
Committed: https://chromium.googlesource.com/chromium/src/+/d0984e8e9374ac9926dd9f41ad873c0c0abd90b3

[Eugene But (OOO till 7-30), 2017-02-21 23:17:21]

eugenebut@chromium.org changed reviewers:
+ rohitrao@chromium.org

[Eugene But (OOO till 7-30), 2017-02-21 23:17:25]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 23:19:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rohitrao (ping after 24h), 2017-02-21 23:21:14]

lgtm

[rohitrao (ping after 24h), 2017-02-21 23:22:02]

It's probably worth running this through the public EG trybots before
submitting.

[Eugene But (OOO till 7-30), 2017-02-21 23:30:04]

On 2017/02/21 23:22:02, rohitrao wrote:
> It's probably worth running this through the public EG trybots before
> submitting.
Of course. 

Thanks for a quick review!

[Eugene But (OOO till 7-30), 2017-02-22 00:24:06]

The CQ bit was unchecked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2017-02-22 00:24:09]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2017-02-22 00:25:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 01:24:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 01:24:49]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[Eugene But (OOO till 7-30), 2017-02-22 23:16:04]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2017-02-22 23:17:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 23:47:59]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487805364157680, "parent_rev":
"090c3e70b9886ec428420dd6b3b0011907b61e16", "commit_rev":
"d0984e8e9374ac9926dd9f41ad873c0c0abd90b3"}

[commit-bot: I haz the power, 2017-02-22 23:48:36]

Description was changed from

==========
Do not use TabModel inside BlockedPopupInfo handler block.

BlockedPopupInfo handler block will be folded into BlockedPopupHandler
which does not have access to TabModel.

Calling updateSnapshotWithOverlay:visibleFrameOnly: is unnecessary,
because it is called from TabInfoBarObserver::OnInfoBarRemoved.

Opening popup functionality was moved to
WebStateDelegate::OpenURLFromWebState, which is currently BVC.

BUG=692117
==========

to

==========
Do not use TabModel inside BlockedPopupInfo handler block.

BlockedPopupInfo handler block will be folded into BlockedPopupHandler
which does not have access to TabModel.

Calling updateSnapshotWithOverlay:visibleFrameOnly: is unnecessary,
because it is called from TabInfoBarObserver::OnInfoBarRemoved.

Opening popup functionality was moved to
WebStateDelegate::OpenURLFromWebState, which is currently BVC.

BUG=692117

Review-Url: https://codereview.chromium.org/2705113004
Cr-Commit-Position: refs/heads/master@{#452278}
Committed:
https://chromium.googlesource.com/chromium/src/+/d0984e8e9374ac9926dd9f41ad87...
==========

[commit-bot: I haz the power, 2017-02-22 23:48:37]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d0984e8e9374ac9926dd9f41ad87...