Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Unified Diff: ios/chrome/browser/ui/browser_view_controller.mm

Issue 2705113004: Do not use TabModel inside BlockedPopupInfo handler block. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/tabs/tab.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/browser_view_controller.mm
diff --git a/ios/chrome/browser/ui/browser_view_controller.mm b/ios/chrome/browser/ui/browser_view_controller.mm
index 102e29ed46b11aa2b499b3eed04a69cbe1d124f6..04a2708e8e9f170fc7165cf3e0b6820a43492718 100644
--- a/ios/chrome/browser/ui/browser_view_controller.mm
+++ b/ios/chrome/browser/ui/browser_view_controller.mm
@@ -2376,6 +2376,18 @@ class BrowserBookmarkModelBridge : public bookmarks::BookmarkModelObserver {
webState->GetNavigationManager()->LoadURLWithParams(loadParams);
return webState;
}
+ case WindowOpenDisposition::NEW_POPUP: {
+ Tab* tab = [[self tabModel]
+ insertOrUpdateTabWithURL:params.url
+ referrer:params.referrer
+ transition:params.transition
+ windowName:nil
+ opener:LegacyTabHelper::GetTabForWebState(webState)
+ openedByDOM:YES
+ atIndex:TabModelConstants::kTabPositionAutomatically
+ inBackground:NO];
+ return tab.webState;
+ }
default:
NOTIMPLEMENTED();
return nullptr;
« no previous file with comments | « ios/chrome/browser/tabs/tab.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698