Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 270503004: Revert 268650 "Reduce footprint of registry controlled domain table" (Closed)

Created:
6 years, 7 months ago by Ryan Sleevi
Modified:
6 years, 7 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 268650 "Reduce footprint of registry controlled domain table" Broke GN bot > Reduce footprint of registry controlled domain table > > The perfect hash table containing all registry controlled domains is > replaced by a compact graph (a dafsa) to reduce binary size and PSS > of the running process. Size of the new structure is about 33kB > compared to 380kB for the perfect hash table. > > Patch by Olle Liljenzin <ollel@opera.com>;, originally at https://codereview.chromium.org/197183002/ > > BUG=370672 > > Review URL: https://codereview.chromium.org/274443003 TBR=rsleevi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268651

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -2197 lines) Patch
A + trunk/src/net/base/registry_controlled_domains/effective_tld_names.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/net/base/registry_controlled_domains/effective_tld_names_unittest1.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/net/base/registry_controlled_domains/effective_tld_names_unittest2.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D trunk/src/net/base/registry_controlled_domains/effective_tld_names_unittest3.gperf View 1 chunk +0 lines, -13 lines 0 comments Download
D trunk/src/net/base/registry_controlled_domains/effective_tld_names_unittest4.gperf View 1 chunk +0 lines, -523 lines 0 comments Download
D trunk/src/net/base/registry_controlled_domains/effective_tld_names_unittest5.gperf View 1 chunk +0 lines, -9 lines 0 comments Download
D trunk/src/net/base/registry_controlled_domains/effective_tld_names_unittest6.gperf View 1 chunk +0 lines, -9 lines 0 comments Download
M trunk/src/net/base/registry_controlled_domains/registry_controlled_domain.h View 1 chunk +4 lines, -5 lines 0 comments Download
M trunk/src/net/base/registry_controlled_domains/registry_controlled_domain.cc View 3 chunks +49 lines, -174 lines 0 comments Download
M trunk/src/net/base/registry_controlled_domains/registry_controlled_domain_unittest.cc View 7 chunks +18 lines, -166 lines 0 comments Download
M trunk/src/net/net.gyp View 3 chunks +0 lines, -38 lines 0 comments Download
D trunk/src/net/tools/tld_cleanup/PRESUBMIT.py View 1 chunk +0 lines, -32 lines 0 comments Download
M trunk/src/net/tools/tld_cleanup/README View 1 chunk +8 lines, -5 lines 0 comments Download
D trunk/src/net/tools/tld_cleanup/make_dafsa.py View 1 chunk +0 lines, -469 lines 0 comments Download
D trunk/src/net/tools/tld_cleanup/make_dafsa_unittest.py View 1 chunk +0 lines, -757 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ryan Sleevi
6 years, 7 months ago (2014-05-07 01:21:31 UTC) #1
Ryan Sleevi
6 years, 7 months ago (2014-05-07 01:22:15 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r268651.

Powered by Google App Engine
This is Rietveld 408576698