Issue 274443003: Reduce footprint of registry controlled domain table

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 274443003: Reduce footprint of registry controlled domain table (Closed)

Created:
6 years, 7 months ago by Ryan Sleevi

Modified:
6 years, 7 months ago

Reviewers:

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Reduce footprint of registry controlled domain table The perfect hash table containing all registry controlled domains is replaced by a compact graph (a dafsa) to reduce binary size and PSS of the running process. Size of the new structure is about 33kB compared to 380kB for the perfect hash table. Patch by Olle Liljenzin <ollel@opera.com>;, originally at https://codereview.chromium.org/197183002/ BUG=370672 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268650

Patch Set 1 #

Created: 6 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+2201 lines, -459 lines)			Patch
D	net/base/registry_controlled_domains/effective_tld_names_unittest1.cc	View	1 chunk	+0 lines, -218 lines	0 comments	Download
D	net/base/registry_controlled_domains/effective_tld_names_unittest2.cc	View	1 chunk	+0 lines, -161 lines	0 comments	Download
A	net/base/registry_controlled_domains/effective_tld_names_unittest3.gperf	View	1 chunk	+13 lines, -0 lines	0 comments	Download
A	net/base/registry_controlled_domains/effective_tld_names_unittest4.gperf	View	1 chunk	+523 lines, -0 lines	0 comments	Download
A	net/base/registry_controlled_domains/effective_tld_names_unittest5.gperf	View	1 chunk	+9 lines, -0 lines	0 comments	Download
A	net/base/registry_controlled_domains/effective_tld_names_unittest6.gperf	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	net/base/registry_controlled_domains/registry_controlled_domain.h	View	1 chunk	+5 lines, -4 lines	0 comments	Download
M	net/base/registry_controlled_domains/registry_controlled_domain.cc	View	3 chunks	+175 lines, -50 lines	0 comments	Download
M	net/base/registry_controlled_domains/registry_controlled_domain_unittest.cc	View	7 chunks	+166 lines, -18 lines	0 comments	Download
M	net/net.gyp	View	3 chunks	+38 lines, -0 lines	0 comments	Download
A	net/tools/tld_cleanup/PRESUBMIT.py	View	1 chunk	+32 lines, -0 lines	0 comments	Download
M	net/tools/tld_cleanup/README	View	1 chunk	+5 lines, -8 lines	0 comments	Download
A	net/tools/tld_cleanup/make_dafsa.py	View	1 chunk	+469 lines, -0 lines	0 comments	Download
A	net/tools/tld_cleanup/make_dafsa_unittest.py	View	1 chunk	+757 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r268650.

Expand Messages | Collapse Messages