Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: trunk/src/net/tools/tld_cleanup/README

Issue 270503004: Revert 268650 "Reduce footprint of registry controlled domain table" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/net/tools/tld_cleanup/PRESUBMIT.py ('k') | trunk/src/net/tools/tld_cleanup/make_dafsa.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/net/tools/tld_cleanup/README
===================================================================
--- trunk/src/net/tools/tld_cleanup/README (revision 268650)
+++ trunk/src/net/tools/tld_cleanup/README (working copy)
@@ -20,9 +20,12 @@
src/build/Debug. It will re-generate
src/net/base/registry_controlled_domains/effective_tld_names.gperf.
-6. Check in the updated effective_tld_names.dat, effective_tld_names.gperf
+6. Run gperf on the new effective_tld_names.gperf:
+ pushd src/net/base/registry_controlled_domains;
+ gperf -a -L "C++" -C -c -o -t -k '*' -NFindDomain -P -K name_offset -D -m 10 \
+ effective_tld_names.gperf > effective_tld_names.cc;
+ popd;
+ It will produce a new effective_tld_names.cc.
-Note that gperf is no longer used for effective_tld_names, but when building
-chromium the file effective_tld_names.gperf will be parsed by make_dafsa.py
-to generate the file effective_tld_names-inc.cc, which is included in
-registry_controlled_domain.cc
+7. Check in the updated effective_tld_names.dat, effective_tld_names.gperf,
+ and effective_tld_names.cc together.
« no previous file with comments | « trunk/src/net/tools/tld_cleanup/PRESUBMIT.py ('k') | trunk/src/net/tools/tld_cleanup/make_dafsa.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698