Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2704983002: MD Bookmarks: Proof-of-concept reimplementation of data storage/binding layer (Closed)

Created:
3 years, 10 months ago by tsergeant
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Bookmarks: Proof-of-concept reimplementation of data storage/binding layer This changes the <bookmarks-store> element to a global singleton which behaves somewhat more sensibly. This is a WIP. TODO: - Fix UI tests - Clean-up TODOs in code - Somehow split CL into something landable BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Patch Set 2 : Rewrite reducers and tree structure #

Patch Set 3 : Split into modules, tweak APIs #

Patch Set 4 : Finish implementing features #

Patch Set 5 : Start writing tests #

Patch Set 6 : More work on tests #

Patch Set 7 : UI Tests #

Patch Set 8 : Cleanup #

Patch Set 9 : Closure annotate page #

Patch Set 10 : Add doc comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1657 lines, -1134 lines) Patch
M chrome/browser/browser_resources.grd View 1 2 3 3 chunks +10 lines, -0 lines 0 comments Download
A chrome/browser/resources/md_bookmarks/actions.html View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/browser/resources/md_bookmarks/actions.js View 1 2 3 4 5 6 7 8 9 1 chunk +148 lines, -0 lines 0 comments Download
A chrome/browser/resources/md_bookmarks/api_listener.html View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/browser/resources/md_bookmarks/api_listener.js View 1 2 3 4 5 6 7 8 9 1 chunk +59 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/app.html View 1 2 3 2 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/app.js View 1 2 3 4 5 6 7 1 chunk +39 lines, -10 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/compiled_resources2.gyp View 1 2 3 4 5 6 7 8 5 chunks +70 lines, -6 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/folder_node.html View 1 2 3 4 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/folder_node.js View 1 2 3 4 5 6 7 8 4 chunks +42 lines, -11 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/item.html View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/item.js View 1 2 3 4 5 6 7 8 4 chunks +24 lines, -7 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/list.html View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/list.js View 1 2 3 4 5 6 7 8 2 chunks +22 lines, -3 lines 0 comments Download
A chrome/browser/resources/md_bookmarks/reducers.html View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/browser/resources/md_bookmarks/reducers.js View 1 2 3 4 5 6 7 8 9 1 chunk +304 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/router.html View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/router.js View 1 2 3 4 5 6 7 2 chunks +36 lines, -13 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/sidebar.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/sidebar.js View 1 2 3 4 5 6 7 8 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/store.html View 1 2 1 chunk +1 line, -9 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/store.js View 1 2 3 4 5 6 7 8 9 1 chunk +62 lines, -446 lines 0 comments Download
A chrome/browser/resources/md_bookmarks/store_client.html View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/browser/resources/md_bookmarks/store_client.js View 1 2 3 4 5 6 7 8 9 1 chunk +88 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/toolbar.js View 1 2 3 4 5 6 3 chunks +11 lines, -1 line 0 comments Download
A chrome/browser/resources/md_bookmarks/types.js View 1 2 3 4 5 6 7 8 9 1 chunk +72 lines, -0 lines 0 comments Download
A chrome/browser/resources/md_bookmarks/util.html View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/browser/resources/md_bookmarks/util.js View 1 2 3 4 5 6 7 8 9 1 chunk +75 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc View 1 2 3 3 chunks +12 lines, -0 lines 0 comments Download
M chrome/test/data/webui/md_bookmarks/item_test.js View 1 2 3 4 5 6 7 1 chunk +18 lines, -30 lines 0 comments Download
M chrome/test/data/webui/md_bookmarks/list_test.js View 1 2 3 4 5 6 3 chunks +58 lines, -7 lines 0 comments Download
M chrome/test/data/webui/md_bookmarks/md_bookmarks_browsertest.js View 1 2 3 4 5 6 1 chunk +21 lines, -6 lines 0 comments Download
A chrome/test/data/webui/md_bookmarks/reducers_test.js View 1 2 3 4 5 1 chunk +257 lines, -0 lines 0 comments Download
M chrome/test/data/webui/md_bookmarks/sidebar_test.js View 1 2 3 4 5 6 2 chunks +23 lines, -27 lines 0 comments Download
A chrome/test/data/webui/md_bookmarks/store_client_test.js View 1 2 3 4 5 6 7 1 chunk +94 lines, -0 lines 0 comments Download
M chrome/test/data/webui/md_bookmarks/store_test.js View 1 2 3 4 5 1 chunk +0 lines, -511 lines 0 comments Download
A chrome/test/data/webui/md_bookmarks/test_store.js View 1 2 3 4 5 6 7 8 1 chunk +42 lines, -0 lines 0 comments Download
M chrome/test/data/webui/md_bookmarks/test_util.js View 1 2 3 4 5 6 2 chunks +3 lines, -11 lines 0 comments Download
M tools/gritsettings/resource_ids View 1 2 1 chunk +17 lines, -17 lines 0 comments Download

Dependent Patchsets:

Issue 2722083002 Patch 20001
Issue 2722083002 Patch 40001
Issue 2733123003 Patch 20001
Issue 2733123003 Patch 40001

Messages

Total messages: 8 (7 generated)
tsergeant
3 years, 9 months ago (2017-03-21 03:05:55 UTC) #8
Message was sent while issue was closed. 
Closing this CL: This CL has landed in several chunks, and is now actively in
use. See https://crbug.com/697706 for details.

Powered by Google App Engine
This is Rietveld 408576698