Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2722083002: [MD Bookmarks] Flatten sidebar. (Closed)

Created:
3 years, 9 months ago by calamity
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD Bookmarks] Flatten sidebar. This CL flattens the MD Bookmarks sidebar into a simple list structure where each node is a single item in a dom-repeat, rather than using a nested node structure. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+381 lines, -99 lines) Patch
M chrome/browser/resources/md_bookmarks/app.js View 1 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/folder_node.html View 1 3 chunks +1 line, -11 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/folder_node.js View 1 4 chunks +16 lines, -11 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/reducers.js View 1 2 chunks +100 lines, -29 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/sidebar.html View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/sidebar.js View 1 2 1 chunk +7 lines, -3 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/types.js View 1 1 chunk +18 lines, -3 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/util.js View 1 2 chunks +47 lines, -1 line 0 comments Download
M chrome/test/data/webui/md_bookmarks/reducers_test.js View 1 2 chunks +182 lines, -36 lines 0 comments Download

Depends on Patchset:

Issue 2704983002 Patch 200001

Messages

Total messages: 2 (2 generated)
calamity
Description was changed from ========== asdf Signed-off-by: Christopher Lam <calamity@chromium.org> asdf asdf asdf asdf asdf ...
3 years, 9 months ago (2017-03-01 06:30:54 UTC) #1
calamity
3 years, 9 months ago (2017-03-02 02:05:18 UTC) #2 
Description was changed from

==========
asdf

Signed-off-by: Christopher Lam <calamity@chromium.org>

asdf


asdf


asdf


asdf


asdf


Merge branch 'tim_rearchitect' into flatten_sidebar


puase

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Bookmarks] Flatten sidebar.

This CL flattens the MD Bookmarks sidebar into a simple list structure
where each node is a single item in a dom-repeat, rather than using a
nested node structure.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

Powered by Google App Engine
This is Rietveld 408576698